Run formatting scripts during PR builds #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
webapp
|
need to test |
glahaye
previously approved these changes
Aug 8, 2023
alliscode
previously approved these changes
Aug 8, 2023
github-actions
bot
added
the
documentation
dehoward
force-pushed
the
add-format-workflows
branch
from
d56b901
to
e11ac68
Compare
alliscode
previously approved these changes
Aug 8, 2023
alliscode
approved these changes
Aug 8, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> brings in the renaming/consolidation changes from microsoft#60 and adds the format scripts to run as part of PR builds. hopefully one day we will have automated fixing of the formatting errors, but for now they must be fixed by the developer manually. ### Description - fixes all formatting errors. - updates READMEs to use relative links where possible since absolute links are not caught by `markdown-link-check`. - github workflows: - adds `copilot-format-frontend` which runs `yarn format` to check if formatting is correct. - renames `node-pr` to `copilot-build-frontend` and removes the `find-yarn-projects` job from the workflow. - removes `copilot-chat-package` in favor of `copilot-build-backend` since the two workflows seem identical. also changes `copilot-build-backend` to run `dotnet format`, and also run when PRs are created. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
brings in the renaming/consolidation changes from #60 and adds the format scripts to run as part of PR builds.
hopefully one day we will have automated fixing of the formatting errors, but for now they must be fixed by the developer manually.
Description
markdown-link-check.copilot-format-frontendwhich runsyarn formatto check if formatting is correct.node-prtocopilot-build-frontendand removes thefind-yarn-projectsjob from the workflow.copilot-chat-packagein favor ofcopilot-build-backendsince the two workflows seem identical.also changes
copilot-build-backendto rundotnet format, and also run when PRs are created.Contribution Checklist