-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update local deployment scripts and main readme for quickstart #94
Merged
alliscode
merged 13 commits into
microsoft:main
from
momuno:momuno/update-readme-local-deploy-scripts
Aug 2, 2023
Merged
Update local deployment scripts and main readme for quickstart #94
alliscode
merged 13 commits into
microsoft:main
from
momuno:momuno/update-readme-local-deploy-scripts
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omuno/chat-copilot into momuno/fix-local-deploy-scripts-readme
…script, remove unised config ps script in webapi/
…o. Add command to stop backend api process when running start script
github-actions
bot
added
documentation
Improvements or additions to documentation
webapi
Pull requests that update .net code
PR: ready for review
labels
Aug 2, 2023
replaces PR #71 |
4 tasks
alliscode
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use an updated screenshot of chat-copilot UI in the README? That one is missing a lot of the new goodness.
alliscode
previously approved these changes
Aug 2, 2023
alliscode
approved these changes
Aug 2, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…soft#94) ### Motivation and Context 1. Why is this change required? To make onboarding smoother. 2. What problem does it solve? The quick-start local deployment steps were difficult to follow. 3. What scenario does it contribute to? Anyone trying out Chat Copilot locally for the first time. 4. If it fixes an open issue, please link to the issue here. NA. ### Description Main Chat Copilot Readme is updated to present a quick-start beginner use case. This is the local deployment of Chat Copilot, not an Azure deployment. It removes the redirect for the scripts, and formats instructions to improve readability. Bash and PowerShell scripts are also fixed to use environment variable `ASPNETCORE_ENVIRONMENT`, which is necessary for appsettings.json override (by appsettings.Development.json) when running the backend for OpenAI. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mollie Munoz <[email protected]> Co-authored-by: Gil LaHaye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Main Chat Copilot Readme is updated to present a quick-start beginner use case. This is the local deployment of Chat Copilot, not an Azure deployment. It removes the redirect for the scripts, and formats instructions to improve readability.
Bash and PowerShell scripts are also fixed to use environment variable
ASPNETCORE_ENVIRONMENT
, which is necessary for appsettings.json override (by appsettings.Development.json) when running the backend for OpenAI.Contribution Checklist