Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dotnet-framework-docker pipelines to 1ES Pipeline templates #1116

Merged

Conversation

lbussell
Copy link
Collaborator

@lbussell lbussell commented Mar 20, 2024

This PR contains changes from #1112

Part of https://github.com/dotnet/dotnet-docker-internal/issues/4475

Server 2016 images have pipeline templates support now. This is a draft PR since validation is still running but I am fairly confident in the changes. I will submit a follow-up PR to docker-tools for the eng/common changes once validation is successful.

2016 test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2409603&view=results
2019 & 2022 test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2409701&view=results

Samples test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2409869&view=results

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of test failure which looks intermitent, LGTM

@lbussell
Copy link
Collaborator Author

The server 2019 & 2022 test run had some test failures which need to be investigated. They don't seem to be intermittent.

@lbussell lbussell changed the title Move dotnet-framework-docker piepline to 1ES Pipeline templates Move dotnet-framework-docker pieplines to 1ES Pipeline templates Mar 20, 2024
@lbussell
Copy link
Collaborator Author

I updated this with samples changes since they are ready.

@lbussell
Copy link
Collaborator Author

Filed #1117 for the public PR validation failure that seems unrelated to this change.

@lbussell lbussell force-pushed the loganbussell/dotnet-framework-docker-1espt branch from 5edfd5c to 120f14b Compare March 21, 2024 17:21
@lbussell lbussell changed the title Move dotnet-framework-docker pieplines to 1ES Pipeline templates Move dotnet-framework-docker pipelines to 1ES Pipeline templates Mar 26, 2024
@lbussell lbussell force-pushed the loganbussell/dotnet-framework-docker-1espt branch from e98b5e4 to c793b27 Compare March 28, 2024 00:04
@lbussell
Copy link
Collaborator Author

lbussell commented Mar 28, 2024

Ready for review. Rebased on latest changes from #1112. We should have a discussion about whether we want all .NET Docker repos to be using the Docker-*-Internal pools or only this repo. That will inform whether we should change what's in eng/common or not. Then I can either submit another PR to docker-tools or update this PR taking the changes out of eng/common.

Successful test run with all 3 OSes: https://dev.azure.com/dnceng/internal/_build/results?buildId=2416434&view=results

@lbussell
Copy link
Collaborator Author

/cc @dagood some new VM images got made for the .NET Fx repo. I saw some runs in the agent pools for golang, so I'm not sure if you're using these or the MMS-based images (like 1es-windows-20XX).

@lbussell
Copy link
Collaborator Author

[Triage] We can merge this and backport eng/common changes to docker-tools. It's likely these will change with https://github.com/dotnet/dotnet-docker-internal/issues/4648 anyways so it's not a big deal to apply it to all repos.

@lbussell lbussell merged commit 18b2868 into microsoft:main Mar 28, 2024
21 checks passed
@dagood
Copy link
Member

dagood commented Apr 1, 2024

some new VM images got made for the .NET Fx repo. I saw some runs in the agent pools for golang, so I'm not sure if you're using these or the MMS-based images (like 1es-windows-20XX).

Ah, thanks. @qmuntal did wind up using Server2016-NESDockerBuilds-PT as part of updating eng/common to fix something else:
microsoft/go-images@74d0cc3#diff-18a2508722ced74b4a1426f61f62289a61b4941a5e48d960c49b259ab807f411
However, we don't currently build any Windows 2016 images. 😄 Windows 1809 and 2022 use 1es-windows-2022.

If you happen to have a list of things that the custom pool/image is (known to be) needed for, it would be interesting to look through to make sure our images aren't silently broken in some way, but it seems to be working fine so far.

(I put together a PR to format our pool choices better based on what I saw in this PR, to make it easier to compare/update in the future: https://github.com/microsoft/go-images/pull/286/files.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants