Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to customize orchestration client timeouts (#427) #445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anttix
Copy link

@anttix anttix commented Feb 7, 2025

Summary of changes

  • Introduce new settings to control orchestration client timeouts
  • Define individual timeouts for client operations that are most often used from http triggered functions / endpoints
  • Modify timeout bucketing not to align short timeouts which would be materially adjusted by the alignment

Key design choices

  • New timeout fields use TimeSpan type. This does not align with existing PartitonStartupTimeoutMinutes field but does align with how timeouts are specified in AzureStorageOrchestrationServiceSettings
  • Define separate timeouts for orchestration creation and message passing calls which are expected to be used most in latency sensitive paths such as http endpoints

Testing done

  • Tested manually with an internal client application

Feedback requested

Please review the use of TimeSpan type and overall fit and finish.

@anttix
Copy link
Author

anttix commented Feb 7, 2025

@microsoft-github-policy-service agree company="Microsoft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant