Add settings to customize orchestration client timeouts (#427) #445
+39
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Key design choices
TimeSpan
type. This does not align with existingPartitonStartupTimeoutMinutes
field but does align with how timeouts are specified in AzureStorageOrchestrationServiceSettingsTesting done
Feedback requested
Please review the use of
TimeSpan
type and overall fit and finish.