Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hostname CLUSTER MEET #1048

Merged
merged 9 commits into from
Feb 28, 2025
Merged

Conversation

vazois
Copy link
Contributor

@vazois vazois commented Feb 24, 2025

This PR fixes #1042. In hindsight, it fixes also #1036 as now users should be able to use localhost in CLUSTER MEET.
The fix probes all IP addresses returned by Dns.GetHostEntry to see which one is actively listening on the corresponding port.

This PR adds the following

  • Allow support of hostnames when calling cluster meet
  • Allow for Garnet to bind to a hostname with --bind option

NOTES:

  1. It seems CLUSTER MEET accepts only IP address and not hostnames
  2. After Redis version 6.2, redis-cli will perform hostname resolution and issue CLUSTER MEET to a specific address, while for version 6.2 and earlier (did not test it for previous versions but I assume it holds) it will not resolve the hostname. Similarly, the redis server cannot be bound to a hostname using bind option in the configuration.
  3. Currently, Garnet did not support binding on a hostname.

@vazois vazois force-pushed the vazois/hostname-gossip branch from a9a99d1 to 52ef284 Compare February 26, 2025 22:00
@vazois vazois marked this pull request as ready for review February 26, 2025 22:01
@vazois vazois force-pushed the vazois/hostname-gossip branch from e4daccd to 791a391 Compare February 28, 2025 00:07
@TalZaccai TalZaccai merged commit b1ecc60 into microsoft:main Feb 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in the latest versions, cluster creation "Waiting for the cluster to join" is infinite
3 participants