Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose GarnetClientSession in Parallel ACL SETUSER Test #1062

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Dispose GarnetClientSession in Parallel ACL SETUSER Test #1062

merged 1 commit into from
Feb 28, 2025

Conversation

kevinmichaelbowersox
Copy link
Member

@kevinmichaelbowersox kevinmichaelbowersox commented Feb 28, 2025 •
edited
Loading

In the ParallelTests#ParallelAclSetUser test one of the GarnetClientSessions was not being disposed of properly. This pull request adds the using statement to properly dispose of the client.

This may be the cause of a sporadic pipeline failure where the ParallelAuthTest that follows ParallelAclSetUser is experiencing a System.AccessViolationException.

@TalZaccai TalZaccai merged commit 4b243c4 into microsoft:main Feb 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinmichaelbowersox @TalZaccai