Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for .Net 9 #919

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ab4517d
net9 changes
TedHartMS Jan 8, 2025
ed7cd27
Merge remote-tracking branch 'origin/main' into tedhar/net9
TedHartMS Jan 8, 2025
5f996a0
Collection expression fix
TedHartMS Jan 9, 2025
8b3d966
Fixing SYSLIB0057
TalZaccai Jan 9, 2025
44874e1
Removing ServicePointManager
TalZaccai Jan 9, 2025
2340ba5
Temporary fix for RedisCallErrors test failing in .net9
TalZaccai Jan 16, 2025
0cb7ff7
merging with latest main
TalZaccai Jan 17, 2025
8059a3a
some fixes
TalZaccai Jan 17, 2025
80b3dc4
Merge branch 'main' into tedhar/net9
TalZaccai Jan 17, 2025
84cc8cd
Added .net90 to CI and the Nightly GitHub Action
darrenge Jan 22, 2025
d0d948a
Fixed Garnet Worker to be both .net80 and .net90 and updated ADO pipe…
darrenge Jan 22, 2025
121d14f
Updated Tsav CI that runs in ADO when mirrored
darrenge Jan 22, 2025
faae98a
Fix to RedisCallErrors
TalZaccai Jan 23, 2025
2b67210
test
TalZaccai Jan 23, 2025
3e3ed56
fix
TalZaccai Jan 23, 2025
d94a323
Skipping RedisCallErrors test
TalZaccai Jan 23, 2025
b49a1b5
Merge branch 'tedhar/net9' of https://github.com/microsoft/garnet int…
darrenge Jan 23, 2025
a74e664
Reverting ignored test
TalZaccai Jan 23, 2025
0214669
Updating CI
TalZaccai Jan 23, 2025
ebd5f05
CI fix
TalZaccai Jan 23, 2025
3fc3ffe
Ignoring RedisCallErrors test when environment variable is not set
TalZaccai Jan 23, 2025
027fe0e
Added net90 to the external release pipeline. Required changed to pub…
darrenge Jan 24, 2025
99621f7
Merge branch 'tedhar/net9' of https://github.com/microsoft/garnet int…
darrenge Jan 24, 2025
0d668ec
Fixed bug in compressed file directory
darrenge Jan 24, 2025
2cedd73
Another try on fixing the destination directory issue
darrenge Jan 24, 2025
c82efda
Added CodeQL.yml which is custom so it works with net90 as well. Upda…
darrenge Jan 29, 2025
064ac3f
merging with latest main
TalZaccai Jan 30, 2025
37e1cbd
Set RunTImes to only be packed once since they are C++ and not depend…
darrenge Jan 30, 2025
078c297
Fixed broken merge
TalZaccai Jan 30, 2025
ffff185
Merge branch 'tedhar/net9' of https://github.com/microsoft/garnet int…
TalZaccai Jan 30, 2025
039499f
Added WorkFlow dispatch and commented out net90
darrenge Jan 30, 2025
9f3b2a6
Added net90 to CodeQL
darrenge Jan 30, 2025
ff9e9e4
Enabled the Create GH Release and Push Nuget packages tasks so it is …
darrenge Jan 30, 2025
939e97a
Merge branch 'main' into tedhar/net9
darrenge Jan 30, 2025
3dd2172
Merge branch 'main' into tedhar/net9
darrenge Jan 31, 2025
a729bf2
merging with latest main
TalZaccai Feb 18, 2025
9cbe7f5
format
TalZaccai Feb 18, 2025
1554339
format
TalZaccai Feb 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
TalZaccai committed Jan 23, 2025
commit 2b672109488ec7db787979636c99265ed6d4c712
6 changes: 0 additions & 6 deletions test/Garnet.test/LuaScriptTests.cs
Original file line number Diff line number Diff line change
@@ -555,12 +555,6 @@ public void ScriptExistsMultiple()

private void DoErroneousRedisCall(IDatabase db, string[] args, string expectedError)
{
// This is a temporary fix to address a regression in .NET9, an open issue can be found here - https://github.com/dotnet/runtime/issues/111242
// Once the issue is resolved this test will fail and the #if can be removed permanently.
#if NET9_0_OR_GREATER
expectedError = "ERR External component has thrown an exception.";
#endif

var exc = Assert.Throws<RedisServerException>(() => db.ScriptEvaluate($"return redis.call({string.Join(',', args)})"));
ClassicAssert.IsNotNull(exc);
StringAssert.StartsWith(expectedError, exc!.Message);