Add SETIFGREATER ETag command #968
Open
+389
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrishc
reviewed
Jan 28, 2025
|
|
||
| /// <summary> | ||
| /// SETIFGREATER key val etag [EX|PX] [expiry] | ||
| /// Sets a key value pair with the given ETag only if the already existing etag is less than the etag given in request. |
There was a problem hiding this comment.
Reword as:
Sets a key value pair with the given etag only if (1) the etag given in the request is greater than the already existing etag ; or (2) there was no existing value; or (3) the existing value was not associated with any etag.
There was a problem hiding this comment.
SetIfGreater on non-existing value returns nil, same as SETIFMATCH
There was a problem hiding this comment.
so 1 and 3 are correct but not 2^
There was a problem hiding this comment.
it should be true, right? otherwise client has to special case the first insert which is wasteful. (we think of the default etag and non-existent etag as zero implicitly)
badrishc
reviewed
Jan 28, 2025
badrishc
reviewed
Jan 28, 2025
badrishc
reviewed
Jan 28, 2025
hamdaankhalid
force-pushed
the
hkhalid/add-setifgreater
branch
from
630ec0d to
c38526e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the SETIFGREATER ETag command along with documentation and testing