fix choice renderting in trace

microsoft · Feb 1, 2025 · 0e07788 · 0e07788
1 parent 1f9a226
commit 0e07788
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/core/src/chat.ts b/packages/core/src/chat.ts
@@ -913,7 +913,12 @@ async function choicesToLogitBias(
             ]
         })
     )
-    trace.itemValue("choices", choices.join(", "))
+    trace.itemValue(
+        "choices",
+        choices
+            .map((c) => (typeof c === "string" ? c : JSON.stringify(c)))
+            .join(", ")
+    )
     trace.itemValue("logit bias", JSON.stringify(logit_bias))
     return logit_bias
 }

diff --git a/packages/core/src/think.test.ts b/packages/core/src/think.test.ts
@@ -6,23 +6,23 @@ describe("convertThinkToMarkdown", () => {
     test("should convert <think> tags to <details> tags", () => {
         const input = "<think>This is \na test</think>"
         const expected =
-            "<details><summary>🤔 think</summary>This is \na test</details>"
+            "\n<details><summary>🤔 think</summary>This is \na test</details>\n"
         const result = convertThinkToMarkdown(input)
         assert.equal(result, expected)
     })
 
     test("should handle multiple <think> tags", () => {
         const input = "<think>First</think> and <think>Second</think>"
         const expected =
-            "<details><summary>🤔 think</summary>First</details> and <details><summary>🤔 think</summary>Second</details>"
+            "\n<details><summary>🤔 think</summary>First</details>\n and \n<details><summary>🤔 think</summary>Second</details>\n"
         const result = convertThinkToMarkdown(input)
         assert.equal(result, expected)
     })
 
     test("should handle <think> tags without closing tags", () => {
         const input = "<think>This is a test"
         const expected =
-            "<details><summary>🤔 thinking...</summary>This is a test</details>"
+            "\n<details><summary>🤔 thinking...</summary>This is a test</details>\n"
         const result = convertThinkToMarkdown(input)
         assert.equal(result, expected)
     })