Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default llm retry logic to be more optimized #1701

Merged
merged 14 commits into from
Feb 13, 2025

Conversation

jgbradley1
Copy link
Collaborator

@jgbradley1 jgbradley1 commented Feb 12, 2025

Description

This PR makes changes to provide a more optimized retry logic for graphrag by default. It also simplifies the configuration by removing config variables that do not provide much value.

Proposed Changes

There are two significant behavioral changes to take note of (can be disabled if users don't wish to use it)

  • switch to using max_retries in the openai library
  • dynamically set the value of max_retries in each step of the indexing pipeline based on the input dataset size

As default behavior, these changes will cause graphrag's retry-logic to utilize the response back from OpenAI to determine how long to wait until it retries an LLM call (i.e. server-side retry logic), as opposed to retry logic that is based on the client-side only. This is done by calculating optimal values for the max_retries parameter when instantiating an openai client. Note that the openai library now has support for the retry-after header (providing a more accurate estimate of time to wait between LLM calls)...so if graphrag bases its' retry-logic entirely on the openai library, this approach should allow us to achieve full quota utilization with fewer configuration variables needed by graphrag.

For users that don't want to use the dynamic retry logic, it can be disabled and other retry-logic is exposed in the configuration file (tokens_per_minute and requests_per_minute).

This dynamic retry logic was tested on two separate AOAI models, with 10K TPM and 400K TPM, to evaluate effectiveness. I also tested across different dataset sizes as well and did not any experience errors due to graphrag reaching the max number of retries for an LLM call.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

Additional Notes

[Add any additional notes or context that may be helpful for the reviewer(s).]

@jgbradley1 jgbradley1 requested review from a team as code owners February 12, 2025 23:39
@jgbradley1 jgbradley1 merged commit f14cda2 into main Feb 13, 2025
15 checks passed
@jgbradley1 jgbradley1 deleted the joshbradley/improve-llm-retry-logic branch February 13, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants