-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: remove kiota interop tight coupling #6096
base: main
Are you sure you want to change the base?
Task: remove kiota interop tight coupling #6096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the addition of parameter names to the functions. It's made reviewing a lot easier. Thanks for that.
vscode/microsoft-kiota/src/commands/generate/generateClientCommand.ts
Outdated
Show resolved
Hide resolved
vscode/microsoft-kiota/src/commands/generate/generateClientCommand.ts
Outdated
Show resolved
Hide resolved
vscode/microsoft-kiota/src/commands/migrate/migrateFromLockFile.util.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments on the PR.
|
Overview
Closes #6084
Notes
Introduces a new module to decouple the Kiota Interop code from the VS Code extension. The most significant changes involve the addition of unit tests, and refactoring of command implementations of the interop module by moving all of them away into the module.
Changes
Application folder
>{AppData}\Microsoft Kiota\.kiotabin
regardless of OS. Moving the.kiotabin
folder outside of the vscode extension environment enabling sharing with different apps on the same devicevscode
were removed from the kiota interop codeconnectToKiota
have moved to the module library as independent functions exported via theindex.ts
fileruntime.json
file with the intent to ship it together with the module so that it can carry the binary information (in theruntimeDependencies
property) and thekiotaVersion
number.package.json
file in the vscode extension no-longer carries theruntimeDependencies
andkiotaVersion
properties.