address comments

microsoft · Jan 9, 2025 · b325728 · b325728
1 parent 28955b3
commit b325728
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/platform/datapath_winkernel.c b/src/platform/datapath_winkernel.c
@@ -600,6 +600,9 @@ CxPlatDataPathQuerySockoptSupport(
 
     } while (FALSE);
 
+    //
+    // Some USO/URO bug blocks TTL feature support on Windows Server 2022.
+    //
     if (CxPlatform.dwBuildNumber != 20348) {
         Datapath->Features |= CXPLAT_DATAPATH_FEATURE_TTL;
     }

diff --git a/src/platform/datapath_winuser.c b/src/platform/datapath_winuser.c
@@ -700,6 +700,10 @@ CxPlatDataPathQuerySockoptSupport(
         Datapath->Features |= CXPLAT_DATAPATH_FEATURE_RECV_COALESCING;
     }
 }
+
+    //
+    // Some USO/URO bug blocks TTL feature support on Windows Server 2022.
+    //
     if (CxPlatform.dwBuildNumber != 20348) {
         Datapath->Features |= CXPLAT_DATAPATH_FEATURE_TTL;
     }
@@ -819,6 +823,9 @@ DataPathInitialize(
     // Check for port reservation support.
     //
 #ifndef QUIC_UWP_BUILD
+    //
+    // Only RS5 and newer can use the port reservation feature safely.
+    //
     if (CxPlatform.dwBuildNumber >= 17763) {
         Datapath->Features |= CXPLAT_DATAPATH_FEATURE_PORT_RESERVATIONS;
     }

diff --git a/src/platform/platform_winuser.c b/src/platform/platform_winuser.c
@@ -262,7 +262,7 @@ CxPlatInitialize(
         }
         FreeLibrary(NtDllHandle);
     }
-    CXPLAT_DBG_ASSERT(SuccessfullySetVersion); // TODO: Is the assert here enough or is there an appropritae QUIC_STATUS we return?
+    CXPLAT_DBG_ASSERT(SuccessfullySetVersion); // TODO: Is the assert here enough or is there an appropriate QUIC_STATUS we return?
 
     if (QUIC_FAILED(Status = CxPlatProcessorInfoInit())) {
         QuicTraceEvent(