Fix bug where signature is not verified for Java Key Store and add signColumnMasterkeyMetadata API to JKS and AKV #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilgreenbird
requested review from
tkyc,
Jeffery-Wasty,
barryw-mssql and
David-Engel
David-Engel
reviewed
Jul 12, 2023
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerColumnEncryptionAzureKeyVaultProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerColumnEncryptionJavaKeyStoreProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerSecurityUtility.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Engel <[email protected]>
tkyc
approved these changes
Aug 2, 2023
Jeffery-Wasty
approved these changes
Aug 4, 2023
tkyc
pushed a commit
that referenced
this pull request
Aug 17, 2023
…gnColumnMasterkeyMetadata API to JKS and AKV (#2160)
tkyc
added a commit
that referenced
this pull request
Aug 17, 2023
…gnColumnMasterkeyMetadata API to JKS and AKV (#2160) (#2199) Co-authored-by: lilgreenbird <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the following new API to JKS and AKV to sign the column master key metadata and return generated signature: