Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Scatter ops for webworker #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Scatter ops for webworker #220

wants to merge 1 commit into from

Conversation

Manojbhat09
Copy link

Had to implement the pytorch scatter (torch.scatter) for an application.
This is valid with onnx scatter too.
And works

@ghost
Copy link

ghost commented Aug 28, 2020

CLA assistant check
All CLA requirements met.

@Manojbhat09
Copy link
Author

When I do npm run pre-commit it gives this error:

Error: Cannot find module 'C:\Users\manojpc\Documents\Deepen\actual\push\onnxjs\tools\pre-commit'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

@fs-eire
Copy link
Contributor

fs-eire commented Sep 2, 2020

When I do npm run pre-commit it gives this error:

Error: Cannot find module 'C:\Users\manojpc\Documents\Deepen\actual\push\onnxjs\tools\pre-commit'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

the pre-commit hook failed to launch. did you run npm ci and tsc correctly?

@@ -82,6 +82,7 @@
"test_flatten_default_axis",
"test_gather_0",
"test_gather_1",
"test_scatter_0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Manojbhat09
Copy link
Author

Hi @fs-eire I actually created a test for this and it works. Do I create a new pull request now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants