Upgrade react-native to 0.70 #23015
Closed
Upgrade react-native to 0.70 #23015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no suggestions.
Files not reviewed (7)
- js/react_native/android/gradle/wrapper/gradle-wrapper.properties: Language not supported
- js/react_native/e2e/android/build.gradle: Language not supported
- js/react_native/e2e/android/gradle/wrapper/gradle-wrapper.properties: Language not supported
- js/react_native/e2e/android/gradlew: Language not supported
- js/react_native/e2e/android/gradlew.bat: Language not supported
- js/react_native/e2e/package.json: Language not supported
- js/react_native/package.json: Language not supported
Comments skipped due to low confidence (2)
js/react_native/ios/Podfile:22
- Ensure that
flags[:hermes_enabled]is correctly defined and used. Ifflagsorhermes_enabledis not defined, it could lead to runtime errors.
:hermes_enabled => flags[:hermes_enabled],
js/react_native/ios/Podfile:23
- Ensure that
flags[:fabric_enabled]is correctly defined and used. Ifflagsorfabric_enabledis not defined, it could lead to runtime errors.
:fabric_enabled => flags[:fabric_enabled],
|
I think there is also another PR to change yarn to npm for /js/react_native/. Is the plan to upgrade the packages version (this PR) first? |
Yes, the other PR requires upgrading RN to 0.73. But upgrading from 0.69 to 0.73 is a little bit more challenging |
:fabric_enabled => false,
# Conflicts: # js/react_native/android/gradle/wrapper/gradle-wrapper.properties
# Conflicts: # js/react_native/e2e/ios/Podfile # js/react_native/ios/Podfile
|
Duplicated with #23279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades react-native to 7.0
Also adding rnx-kit to help with future react-native upgrades
Motivation and Context