Compile lib instead of executable when checking compiler features #23329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures `check_cxx_compiler_flag` uses `try_compile` with a basic source file. `try_compile` can build a static library, but builds an executable by default. For mobile builds, this means using the SDK to create an app package, which adds unnecessary time to the configuration stage. In particular, I am addressing a problem where an iOS build sometimes hangs during one of these calls, leading to a build timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check_cxx_compiler_flagusestry_compilewith a basic source file.try_compilecan build a static library, but builds an executable by default. For mobile builds, this means using the SDK to create an app package, which adds unnecessary time to the configuration stage.Motivation and Context
In particular, I am addressing a problem where an iOS build on a private project sometimes hangs during one of these calls, leading to a build timeout