[js/web] allow import .mjs/.wasm file #23487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
force-pushed
the
fs-eire/allow-import-dist
branch
from
cf4a7bd to
990964c
Compare
guschmue
approved these changes
Jan 27, 2025
fs-eire
added a commit
that referenced
this pull request
Jan 30, 2025
### Description After some investigation and debug, I decided to follow the recommended workaround as suggested in vitejs/vite#8427. ### Motivation and Context There is a known issue with Vite 5.x when using WebAssembly package. Detail information is in vitejs/vite#8427. There are previous attempts to fix this problem (#23487). I tried various ways to make it working out of the box for Vite users but none of them worked: Some "fixes" did fix the usage of Vite but broke other use case/bundler and some introduced other issues. Eventually I figured out that there is no good way to fix this inside ONNX Runtime. Considering the root cause is inside Vite and it may be fixed in Vite v6. I think now the best way is to follow the recommended workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow importing the
.mjsand.wasmfiles.when using Vite, this enables web app to consume ORT-web for simplify the setup: