Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding -ref.json to multiplayer #5365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding -ref.json to multiplayer #5365

wants to merge 1 commit into from

Conversation

abchatra
Copy link
Collaborator

No description provided.

@abchatra
Copy link
Collaborator Author

I will wait for Eric. I don't think query string works after this though.

@jwunderl
Copy link
Member

Would it be confusing that you can't go to arcade.makecode.com/multiplayer?host=ajskdlfjaklsdfj?

@jwunderl
Copy link
Member

Ah yes, this was something we were discussing as future work to allow it to propagate query string (e.g. could even be something like converting /join/abcdef => /--multiplayer?join=abcdef)

@abchatra
Copy link
Collaborator Author

Yes that is what I was thinking. However, # gets propagated. Probably need backend change. I will pass on to Eric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwunderl jwunderl jwunderl approved these changes

@eanders-ms eanders-ms Awaiting requested review from eanders-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abchatra @jwunderl