Is playing now working, moved block to micro:bit v2 group (#5320)

microsoft · Jul 24, 2023 · 260840f · 260840f
1 parent bbffc70
commit 260840f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/libs/core/music.cpp b/libs/core/music.cpp
@@ -67,12 +67,17 @@ void setBuiltInSpeakerEnabled(bool enabled) {
 * Check whether any sound is being played, no matter the source
 */
 //% blockId=music_sound_is_playing block="sound is playing"
-//% group="Volume"
+//% group="micro:bit (V2)"
 //% help=music/volume
 //% weight=0
 bool isSoundPlaying() {
 #if MICROBIT_CODAL
-    uBit.audio.isPlaying();
+    if (uBit.audio.mixer.getSilenceStartTime() == 0) {
+        return false;
+    } else {
+        return uBit.audio.isPlaying();
+    }
+
 #else
     target_panic(PANIC_VARIANT_NOT_SUPPORTED);
 #endif

diff --git a/libs/core/shims.d.ts b/libs/core/shims.d.ts
@@ -681,7 +681,7 @@ declare namespace music {
      * Check whether any sound is being played, no matter the source
      */
     //% blockId=music_sound_is_playing block="sound is playing"
-    //% group="Volume"
+    //% group="micro:bit (V2)"
     //% help=music/volume
     //% weight=0 shim=music::isSoundPlaying
     function isSoundPlaying(): boolean;