Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder pins, fix pin block location, improve pin patch #5871

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Reorder pins, fix pin block location, improve pin patch #5871

merged 1 commit into from
Aug 28, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Aug 28, 2024 •
edited
Loading

Fixes #5869
Fixes most of #5834

A few fixes:

  • restores the position of the analog pin block which I accidentally deleted
  • removes the unnecessary name overrides in the analog pin enum
  • moves pin 10 back into numerical order instead of the read-write pins first order that we use in live
  • improves the upgrade rule for the analog read pin block so that it uses the new shadow if a read-write pin is selected

@riknoll riknoll requested a review from a team August 28, 2024 17:14
srietkerk
srietkerk reviewed Aug 28, 2024
View reviewed changes
libs/core/_locales/core-strings.json
@@ -7,19 +7,6 @@
"AcceleratorRange.OneG|block": "1g",
"AcceleratorRange.TwoG": "The accelerator measures forces up to 2 gravity",
"AcceleratorRange.TwoG|block": "2g",
"AnalogPin.P11|block": "P11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all of the analog write pins getting removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the "removes the unnecessary name overrides in the analog pin enum" part of the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. they used to be named something like P11 (write only) but I removed that in my last PR so these translations are no longer required

@riknoll riknoll merged commit a545e39 into master Aug 28, 2024
7 checks passed
@riknoll riknoll deleted the dev/riknoll/pins-fixes branch August 28, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srietkerk srietkerk srietkerk left review comments

@thsparks thsparks thsparks approved these changes

@jwunderl jwunderl jwunderl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beta: analog pin block is misplaced
4 participants
@riknoll @jwunderl @srietkerk @thsparks