Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running npm audit fix --force #8491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Running npm audit fix --force #8491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88f6b44
Running npm audit fix --force
abchatra Sep 15, 2021
0677509
fixing package-lock json for skillmap
abchatra Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,24 +62,24 @@
"browserify": "16.2.0",
"chai": "^3.5.0",
"cssnano": "4.1.10",
"dompurify": "2.0.8",
"dompurify": "^2.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a package-lock.json, so version numbers should not be loose matches; no ^, ~, etc. We need to ensure that the build machine uses the same package versions we developed with and tested locally. Why are we not using package-lock.json here?

"faye-websocket": "0.11.1",
"karma": "4.4.1",
"karma": "^6.3.4",
"karma-chai": "0.1.0",
"karma-chrome-launcher": "3.1.0",
"karma-mocha": "1.3.0",
"karma-mocha": "^2.0.1",
"less": "2.7.3",
"lzma": "2.3.2",
"marked": "0.3.19",
"mocha": "5.1.0",
"marked": "^3.0.4",
"mocha": "^9.1.1",
"pngjs": "3.4.0",
"postcss": "6.0.21",
"promise.prototype.finally": "^3.1.2",
"puppeteer": "^2.0.0",
"request": "2.88.0",
"rimraf": "2.5.4",
"rtlcss": "2.2.1",
"sanitize-html": "1.22.0",
"sanitize-html": "^2.5.1",
"semantic-ui-less": "2.2.14",
"terser": "5.6.0"
},
Expand Down
111 changes: 58 additions & 53 deletions skillmap/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.