This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Add "size" (used in array literals) to the list of highlighted keywords #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
approved these changes
Mar 23, 2022
bamarsha
reviewed
Mar 23, 2022
| @@ -48,7 +48,7 @@ | |||
| }, | |||
| { | |||
| "name": "keyword.other.qsharp", | |||
| "match": "\\b(new|not|and|or|w\/)\\b" | |||
| "match": "\\b(new|not|and|or|w\/|size)\\b" | |||
There was a problem hiding this comment.
The tricky thing about size is that it's not a true keyword like not. It acts like a keyword when it occurs in a specific part of an array literal, but it's still a valid identifier:
let size = 123;
let xs = [size, size = 2]; // first size is a variable, second size is a "keyword"So I am not sure if we want all instances of size highlighted.
There was a problem hiding this comment.
Hmm, let me see if I can make something like "a comma, optional whitespace, size, optional whitespace, equality sign" work without also highlighting the comma and the equality...
raghavthind2005
approved these changes
Apr 26, 2022
|
I didn't get to this in the past month and likely won't get to in the next month, so I've opened #1419 and will close this PR for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.