Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Fixing piplines (cargo.lock, clang 16, ubuntu 20.04, CLI11, etc.) #1151

Merged
merged 11 commits into from
Aug 31, 2023

Conversation

sezna
Copy link
Contributor

@sezna sezna commented Aug 29, 2023

  • Commit a lockfile to prevent dependency updates from breaking us
  • Remove superfluous toolchain installs in prerequisites.ps1
    • rustup install and rustup toolchain install are the same command
    • we only need to install the toolchain we use in the CI
  • Pin cargo-edit version to v0.11.0, which is compatible with our rust version
  • Pin backtrace version to v0.3.65
  • Updated runtime repo to use clang 16.0.6. Based on this PR for the previous update.

In cargo-land, the semver string x.y.z will actually resolve to anything greater than or equal to x.y.z. It appears that a lot of projects don't consider updating their minimal supported Rust version a breaking change. As we didn't have a lockfile, cargo picked the new patch version with a newer Rust toolchain requirement, which broke us. We should update our Rust version eventually, but I'd consider that a different issue that can be handled in a follow-up PR.

For now, pinning some dependencies has allowed me to generate a compatible lockfile. That lockfile will protect us from this happening again.

@DmitryVasilevsky DmitryVasilevsky changed the title Commit lockfile to pin dependencies Fixing piplines (cargo.lock, clang 16, ubuntu 20.04, CLI11, etc.) Aug 30, 2023
@DmitryVasilevsky DmitryVasilevsky marked this pull request as ready for review August 30, 2023 23:07
@swernli swernli enabled auto-merge (squash) August 30, 2023 23:10
@swernli swernli merged commit 5df4b7a into main Aug 31, 2023
33 checks passed
@swernli swernli deleted the alex/pipeline-fix branch August 31, 2023 00:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants