upgrade nx to 13.10.6 #2562
Open
upgrade nx to 13.10.6 #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
gaugup
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following up on PR:
#2561
Our nx version is very old (3-4 years old) which started to cause build gate failures. The previous PR upgraded nx to latest 12.x version to fix build failures and this next PR upgrades it to 13.x version. The latest nx release is at 18.x but even if we get it to 17.x I think that would be sufficient for now, and upgrading will also probably allow us to build on node 18.x which has many enhancements.
We are doing this nx upgrade one major version at a time as recommended here:
https://nx.dev/recipes/tips-n-tricks/advanced-update#one-major-version-at-a-time-small-steps
I also tried to upgrade all in one migration but I got too many failures and it was very difficult to fix all of them at once.
Checklist