[rush] Fix edge cases where Rush does not update the lockfile

common/changes/@microsoft/rush/fix-edge-case-rush-does-not-update-lockfile_2024-08-30-06-44.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where moving dependencies from `dependencies` to `devDependencies` in a project's `package.json` did not trigger an lockfile update.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}

libraries/rush-lib/src/logic/pnpm/PnpmShrinkwrapFile.ts

@@ -1002,9 +1002,9 @@ export class PnpmShrinkwrapFile extends BaseShrinkwrapFile {
             }
             // If fall through, there is a chance the package declares an inconsistent version, ignore it.
             isDevDepFallThrough = true;
+            break;
           }
 
-          // eslint-disable-next-line no-fallthrough
           case DependencyType.Regular:
             specifierFromLockfile = importer.dependencies?.[name];
             importerDependencies.delete(name);

libraries/rush-lib/src/logic/pnpm/test/PnpmShrinkwrapFile.test.ts

@@ -218,7 +218,7 @@ describe(PnpmShrinkwrapFile.name, () => {
             project,
             project.rushConfiguration.defaultSubspace
           )
-        ).resolves.toBe(false);
+        ).resolves.toBe(true);
       });
     });
   });