Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MSTest analyzers #898

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

Youssef1313
Copy link
Member

No description provided.

@Youssef1313 Youssef1313 requested a review from a team as a code owner January 23, 2025 16:44
@Youssef1313
Copy link
Member Author

@DaveTryon Could you run the pipeline here and get this merged if green please? Thank you

@DaveTryon
Copy link
Contributor

/azp run

@Youssef1313
Copy link
Member Author

@DaveTryon This is green and should hopefully be good to merge.

@DaveTryon
Copy link
Contributor

@Youssef1313, will you please change all of these options to error ? If we're going to follow these rules, let's really follow them. Tests build and run successfully, so we've already completed the "get clean" part of "get clean/stay clean". Thanks!

@Youssef1313
Copy link
Member Author

@DaveTryon warnings should be enough, I think, as you are already treating warnigns as errors:

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>

@DaveTryon
Copy link
Contributor

/azp run

@DaveTryon DaveTryon merged commit 720222c into microsoft:main Jan 28, 2025
4 checks passed
@Youssef1313 Youssef1313 deleted the mstest-analyzers branch January 29, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants