Address a targeted set of analyzer warnings

.editorconfig

@@ -461,7 +461,7 @@ stylecop.documentation.xmlHeader = false
 
 # SA1623: Property summary documentation must match accessors
 # Justification: It's noise to start a summary with "Gets" or "Sets"
-# https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1200.md
+# https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1623.md
 dotnet_diagnostic.SA1623.severity = none
 
 # CA1859: Use concrete types when possible
@@ -543,7 +543,7 @@ dotnet_diagnostic.SA1204.severity = suggestion
 
 # https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1207.md
 # SA1207: Member attributes should follow the order
-dotnet_diagnostic.SA1207.severity = suggestion
+dotnet_diagnostic.SA1207.severity = error
 
 # https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1214.md
 # SA1214: Readonly fields must appear before non-readonly fields
@@ -615,11 +615,11 @@ dotnet_diagnostic.SA1622.severity = suggestion
 
 # https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1625.md
 # SA1625: Element documentation should not be copied and pasted
-dotnet_diagnostic.SA1625.severity = suggestion
+dotnet_diagnostic.SA1625.severity = error
 
 # https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1626.md
 # SA1626: Single-line comments should not use documentation style slashes
-dotnet_diagnostic.SA1626.severity = suggestion
+dotnet_diagnostic.SA1626.severity = error
 
 # https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1627.md
 # SA1627: Documentation text should not be empty
@@ -631,7 +631,7 @@ dotnet_diagnostic.SA1629.severity = suggestion
 
 # https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1633.md
 # SA1633: File should have header
-dotnet_diagnostic.SA1633.severity = suggestion
+dotnet_diagnostic.SA1633.severity = error
 
 # https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1642.md
 # SA1642: Constructor summary documentation should begin with standard text
@@ -676,7 +676,7 @@ dotnet_diagnostic.CA1032.severity = suggestion
 
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1040
 # CA1040: Avoid empty interfaces
-dotnet_diagnostic.CA1040.severity = suggestion
+dotnet_diagnostic.CA1040.severity = error
 
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1041
 # CA1041: Provide ObsoleteAttribute message
@@ -752,7 +752,7 @@ dotnet_diagnostic.CA1311.severity = suggestion
 
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1508
 # CA1508: Avoid dead conditional code
-dotnet_diagnostic.CA1508.severity = suggestion
+dotnet_diagnostic.CA1508.severity = error
 
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1510
 # CA1510: Use '...' instead of explicitly throwing a new exception instance
@@ -952,7 +952,7 @@ dotnet_diagnostic.CS8632.severity = suggestion
 
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0005
 # IDE0005: Using directive is unnecessary
-dotnet_diagnostic.IDE0005.severity = suggestion
+dotnet_diagnostic.IDE0005.severity = error
 
 # https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0009
 # IDE0009: Add 'this' or 'Me' qualification

src/Microsoft.Sbom.Api/Config/ApiConfigurationBuilder.cs

@@ -25,8 +25,8 @@ public static class ApiConfigurationBuilder
     /// </summary>
     /// <param name="rootPath">Path where package exists. If scanning start here.</param>
     /// <param name="manifestDirPath">Output path to where manifest is generated.</param>
-    /// <param name="files">Use null to scan.</param>
-    /// <param name="packages">Use null to scan.</param>
+    /// <param name="files">Use null to scan all files.</param>
+    /// <param name="packages">Use null to scan all packages.</param>
     /// <param name="metadata"></param>
     /// <param name="specifications"></param>
     /// <param name="runtimeConfiguration"></param>

src/Microsoft.Sbom.Api/Config/Args/FormatValidationArgs.cs

@@ -1,10 +1,6 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System;
-using System.Collections.Generic;
-using Microsoft.Sbom.Api.Utils;
-using Microsoft.Sbom.Extensions.Entities;
 using PowerArgs;
 
 namespace Microsoft.Sbom.Api.Config.Args;

src/Microsoft.Sbom.Api/Config/Args/GenerationAndValidationCommonArgs.cs

@@ -2,10 +2,8 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.Collections.Generic;
-using Microsoft.Sbom.Common.Config;
 using Microsoft.Sbom.Extensions.Entities;
 using PowerArgs;
-using Serilog.Events;
 
 namespace Microsoft.Sbom.Api.Config.Args;
 

src/Microsoft.Sbom.Api/Config/ConfigFileParser.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.IO;
 using System.Text.Json;
 using System.Threading.Tasks;
 using Microsoft.Sbom.Common;

src/Microsoft.Sbom.Api/Config/ConfigPostProcessor.cs

@@ -4,13 +4,10 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
-using System.IO;
-using System.Linq;
 using AutoMapper;
 using Microsoft.Sbom.Api.Output.Telemetry;
 using Microsoft.Sbom.Common;
 using Microsoft.Sbom.Common.Config;
-using Microsoft.Sbom.Common.Config.Attributes;
 using Microsoft.Sbom.Common.Config.Validators;
 using Microsoft.Sbom.Common.Utils;
 using PowerArgs;

src/Microsoft.Sbom.Api/Config/ConfigSanitizer.cs

@@ -3,15 +3,11 @@
 
 using System;
 using System.Collections.Generic;
-using System.IO;
-using System.Linq;
 using System.Reflection;
-using Microsoft.Sbom.Api.Executors;
 using Microsoft.Sbom.Api.Hashing;
 using Microsoft.Sbom.Api.Utils;
 using Microsoft.Sbom.Common;
 using Microsoft.Sbom.Common.Config;
-using Microsoft.Sbom.Common.Config.Attributes;
 using Microsoft.Sbom.Common.Utils;
 using Microsoft.Sbom.Contracts.Enums;
 using Microsoft.Sbom.Extensions.Entities;

src/Microsoft.Sbom.Api/Config/ISbomService.cs

@@ -9,7 +9,9 @@ namespace Microsoft.Sbom.Api.Config;
 /// Marker interface for an SBOM service.
 /// </summary>
 /// <typeparam name="T">The type of arguments against which this service is run.</typeparam>
+#pragma warning disable CA1040 // Avoid empty interfaces
 public interface ISbomService<T>
+#pragma warning restore CA1040 // Avoid empty interfaces
     where T : CommonArgs
 {
 }

src/Microsoft.Sbom.Api/Config/ValueConverters/NullableBoolConfigurationSettingAddingConverter.cs

@@ -28,7 +28,7 @@ public ConfigurationSetting<bool> Convert(bool? sourceMember, ResolutionContext
         return new ConfigurationSetting<bool>
         {
             Source = settingSource,
-            Value = sourceMember ?? false
+            Value = sourceMember.Value
         };
     }
 }

src/Microsoft.Sbom.Api/Executors/EnumeratorChannel.cs

@@ -6,7 +6,6 @@
 using System.Threading.Channels;
 using System.Threading.Tasks;
 using Microsoft.Sbom.Api.Entities;
-using Microsoft.Sbom.Api.Output.Telemetry;
 using Microsoft.Sbom.JsonAsynchronousNodeKit.Exceptions;
 using Serilog;
 

src/Microsoft.Sbom.Api/Executors/FileHasher.cs

@@ -12,7 +12,6 @@
 using Microsoft.Sbom.Api.Manifest;
 using Microsoft.Sbom.Api.Utils;
 using Microsoft.Sbom.Common.Config;
-using Microsoft.Sbom.Contracts;
 using Microsoft.Sbom.Contracts.Enums;
 using Microsoft.Sbom.Entities;
 using Microsoft.Sbom.Extensions;
@@ -73,16 +72,6 @@ public FileHasher(
         ManifestGeneratorProvider manifestGeneratorProvider,
         IFileTypeUtils fileTypeUtils)
     {
-        if (configuration is null)
-        {
-            throw new ArgumentNullException(nameof(configuration));
-        }
-
-        if (manifestGeneratorProvider is null)
-        {
-            throw new ArgumentNullException(nameof(manifestGeneratorProvider));
-        }
-
         this.hashCodeGenerator = hashCodeGenerator ?? throw new ArgumentNullException(nameof(hashCodeGenerator));
         this.manifestPathConverter = manifestPathConverter ?? throw new ArgumentNullException(nameof(manifestPathConverter));
         this.log = log ?? throw new ArgumentNullException(nameof(log));

src/Microsoft.Sbom.Api/Executors/FileListEnumerator.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Channels;
 using System.Threading.Tasks;

src/Microsoft.Sbom.Api/Executors/HashValidator.cs

@@ -6,7 +6,6 @@
 using System.Threading.Tasks;
 using Microsoft.Sbom.Api.Entities;
 using Microsoft.Sbom.Common.Config;
-using Microsoft.Sbom.Contracts;
 using Microsoft.Sbom.Extensions.Entities;
 
 namespace Microsoft.Sbom.Api.Executors;

src/Microsoft.Sbom.Api/Executors/ILicenseInformationFetcher2.cs

@@ -1,10 +1,8 @@
 // Copyright (c) Microsoft. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using Microsoft.ComponentDetection.Contracts.BcdeModels;
 
 namespace Microsoft.Sbom.Api.Executors;
 

src/Microsoft.Sbom.Api/Executors/RelationshipGenerator.cs

@@ -7,7 +7,6 @@
 using System.Threading.Channels;
 using System.Threading.Tasks;
 using Microsoft.Sbom.Api.Manifest;
-using Microsoft.Sbom.Extensions;
 using Microsoft.Sbom.Extensions.Entities;
 
 namespace Microsoft.Sbom.Api.Executors;

src/Microsoft.Sbom.Api/FormatValidator/ValidatedSBOM.cs

@@ -115,14 +115,14 @@ private FormatValidationResults Validate()
             return ValidationDetails;
         }
 
-        if (SPDXVersionParser.VersionMatchesRequiredVersion(sbom?.Version, requiredSpdxMajorVersion))
+        if (SPDXVersionParser.VersionMatchesRequiredVersion(sbom.Version, requiredSpdxMajorVersion))
         {
             ValidationDetails.AggregateValidationStatus(FormatValidationStatus.Valid);
             return ValidationDetails;
         }
 
         ValidationDetails.AggregateValidationStatus(FormatValidationStatus.NotValid);
-        ValidationDetails.Errors.Add($"SBOM version {sbom?.Version} is not recognized as SPDX major version 2.");
+        ValidationDetails.Errors.Add($"SBOM version {sbom.Version} is not recognized as SPDX major version 2.");
         return ValidationDetails;
     }
 

src/Microsoft.Sbom.Api/PackageDetails/ComponentDetailsUtils/RubyGemsUtils.cs

@@ -12,7 +12,6 @@
 using Microsoft.Sbom.Api.Output.Telemetry;
 using Microsoft.Sbom.Common;
 using Serilog;
-using File = System.IO.File;
 
 namespace Microsoft.Sbom.Api.PackageDetails;
 

src/Microsoft.Sbom.Api/Providers/ExternalDocumentReferenceProviders/CGExternalDocumentReferenceProvider.cs

@@ -8,7 +8,6 @@
 using Microsoft.ComponentDetection.Contracts.BcdeModels;
 using Microsoft.Sbom.Api.Converters;
 using Microsoft.Sbom.Api.Entities;
-using Microsoft.Sbom.Api.Exceptions;
 using Microsoft.Sbom.Api.Executors;
 using Microsoft.Sbom.Api.Utils;
 using Microsoft.Sbom.Common.Config;

src/Microsoft.Sbom.Api/Providers/FilesProviders/CGScannedExternalDocumentReferenceFileProvider.cs

@@ -7,7 +7,6 @@
 using System.Threading.Channels;
 using Microsoft.Sbom.Api.Converters;
 using Microsoft.Sbom.Api.Entities;
-using Microsoft.Sbom.Api.Exceptions;
 using Microsoft.Sbom.Api.Executors;
 using Microsoft.Sbom.Api.Utils;
 using Microsoft.Sbom.Common.Config;

src/Microsoft.Sbom.Api/Utils/ComponentDetectorCachedExecutor.cs

@@ -7,7 +7,6 @@
 using Microsoft.ComponentDetection.Contracts.BcdeModels;
 using Microsoft.ComponentDetection.Orchestrator.Commands;
 using Serilog;
-using Spectre.Console.Cli;
 
 namespace Microsoft.Sbom.Api.Utils;
 

src/Microsoft.Sbom.Api/Workflows/Helpers/PackageArrayGenerator.cs

@@ -10,7 +10,6 @@
 using Microsoft.Sbom.Api.Providers;
 using Microsoft.Sbom.Api.Utils;
 using Microsoft.Sbom.Extensions;
-using Microsoft.Sbom.Extensions.Entities;
 using Serilog;
 
 namespace Microsoft.Sbom.Api.Workflows.Helpers;

src/Microsoft.Sbom.Api/Workflows/SBOMRedactionWorkflow.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Text.Json;
 using System.Threading.Tasks;
 using Microsoft.Sbom.Api.FormatValidator;

src/Microsoft.Sbom.Common/Config/IConfiguration.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using Microsoft.Sbom.Common.Config.Attributes;
 using Microsoft.Sbom.Contracts;
 using Microsoft.Sbom.Contracts.Enums;

src/Microsoft.Sbom.Common/FileSystemUtils.cs

@@ -48,7 +48,6 @@ public abstract class FileSystemUtils : IFileSystemUtils
     public string JoinPaths(string root, string relativePath, string secondRelativePath) =>
         Path.Join(root, relativePath, secondRelativePath);
 
-    /// <inheritdoc />
     /// <inheritdoc />
     public string GetRelativePath(string relativeTo, string path) => Path.GetRelativePath(relativeTo, path);
 

src/Microsoft.Sbom.Common/GeneratorUtils.cs

@@ -4,8 +4,6 @@
 namespace Microsoft.Sbom.Common;
 
 using System;
-using System.Collections.Generic;
-using System.IO;
 using System.Linq;
 using Microsoft.Sbom.Contracts;
 using Microsoft.Sbom.Contracts.Enums;

src/Microsoft.Sbom.Common/InternalMetadataProviderIdentityExtensions.cs

@@ -4,11 +4,8 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Security.Cryptography;
-using System.Text;
 using Microsoft.Sbom.Extensions;
 using Microsoft.Sbom.Extensions.Entities;
-using HashAlgorithmName = Microsoft.Sbom.Contracts.Enums.AlgorithmName;
 
 namespace Microsoft.Sbom.Common;
 

src/Microsoft.Sbom.Extensions.DependencyInjection/ServiceCollectionExtensions.cs

@@ -5,7 +5,6 @@
 using Microsoft.ComponentDetection.Orchestrator;
 using Microsoft.ComponentDetection.Orchestrator.Extensions;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Http;
 using Microsoft.Extensions.Logging;
 using Microsoft.Sbom.Api;
 using Microsoft.Sbom.Api.Config;
@@ -41,7 +40,6 @@
 using Serilog.Extensions.Logging;
 using Serilog.Filters;
 using Constants = Microsoft.Sbom.Api.Utils.Constants;
-using IComponentDetector = Microsoft.ComponentDetection.Contracts.IComponentDetector;
 using ILogger = Serilog.ILogger;
 
 namespace Microsoft.Sbom.Extensions.DependencyInjection;
@@ -105,7 +103,7 @@ public static IServiceCollection AddSbomTool(this IServiceCollection services, L
             .AddTransient<RelationshipGenerator>()
             .AddTransient<ConfigSanitizer>()
             .AddTransient<IProcessExecutor, ProcessExecutor>()
-            .AddTransient<Api.Utils.IComponentDetector, ComponentDetector>()
+            .AddTransient<IComponentDetector, ComponentDetector>()
             .AddTransient<IMetadataBuilderFactory, MetadataBuilderFactory>()
             .AddTransient<FileInfoWriter>()
             .AddTransient<ComponentToExternalReferenceInfoConverter>()

src/Microsoft.Sbom.Extensions/Entities/ManifestInfo.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 
 namespace Microsoft.Sbom.Extensions.Entities;
 

src/Microsoft.Sbom.Extensions/Exceptions/MissingHashValueException.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Runtime.Serialization;
 
 namespace Microsoft.Sbom.Extensions.Exceptions;
 

src/Microsoft.Sbom.Parsers.Spdx22SbomParser/Entities/SPDXRelationship.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.Text.Json.Serialization;
-using Microsoft.Sbom.Parsers.Spdx22SbomParser.Entities.Enums;
 
 namespace Microsoft.Sbom.Parsers.Spdx22SbomParser.Entities;
 

src/Microsoft.Sbom.Parsers.Spdx22SbomParser/Entities/Snippet.cs

@@ -3,7 +3,6 @@
 
 namespace Microsoft.Sbom.Parsers.Spdx22SbomParser.Entities;
 
-using System;
 using System.Collections.Generic;
 using System.Text.Json.Serialization;
 

src/Microsoft.Sbom.Parsers.Spdx22SbomParser/Exceptions/MissingHashValueException.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Runtime.Serialization;
 
 namespace Microsoft.Sbom.Parsers.Spdx22SbomParser.Exceptions;