Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Fixed Python bug when enable_json_response=True #10376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Python: Fixed Python bug when enable_json_response=True #10376

wants to merge 2 commits into from
+1 −1

Conversation

shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Feb 3, 2025 •
edited by moonbox3
Loading

Description

Fixed Python bug when enable_json_response=True

Contribution Checklist

Fixes #10375

@shethaadit shethaadit requested a review from a team as a code owner February 3, 2025 18:18
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Feb 3, 2025
@github-actions github-actions bot changed the title Fixed Python bug when enable_json_response=True Python: Fixed Python bug when enable_json_response=True Feb 3, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Feb 3, 2025 •
edited
Loading

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/open_ai
   open_ai_assistant_base.py5211497%188, 197–202, 282, 298–299, 767, 821, 1027, 1035, 1049, 1120, 1184
TOTAL17593236087% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3049 4 💤 2 ❌ 0 🔥 1m 11s ⏱️

@moonbox3
Copy link
Contributor

moonbox3 commented Feb 4, 2025

@shethaadit there are some unit tests that need to be updated (that were incorrectly looking at the enable_json_response config).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonbox3 moonbox3 moonbox3 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
Semantic Kernel
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: Bug: Assistant Agent enable json error
3 participants
@shethaadit @markwallace-microsoft @moonbox3