Pull some small things off the bottom of #637 #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NULL has size zero, which rounds up to zero, and so would have been handled.
The introduction of the remote stub back in #604 renamed this function from `is_empty` but did not flip the return value to match. Do so now.
If we're running with the freelist_backward_edge mitigation turned on, then we're going to follow the pointer, not just de-obfuscate it (in freelist's atomic_read_next), so even if the queue heads are tame, we still need to do this domestication.
This parameter is in fact instantiated with FrontendSlabMetadata, so the use of Backend here is confusing.
mjp41
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, (my) long-running PRs tend to accumulate other, less-relevant things. Pull some of those out for independent review.