Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for BP_Check #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes for BP_Check #310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e02ce1
password quality check
Petar-T Jun 21, 2024
0b0c137
Merge branch 'master' of https://github.com/Petar-T/tigertoolbox
Petar-T Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions BPCheck/Check_BP_Servers.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ CREATE PROCEDURE usp_bpcheck
@ptochecks bit = 1, --(1 = ON; 0 = OFF)
@duration tinyint = 90,
@logdetail bit = 0, --(1 = ON; 0 = OFF)
@diskfrag bit = 1, --(1 = ON; 0 = OFF)
@diskfrag bit = 0, --(1 = ON; 0 = OFF)
@ixfrag bit = 1, --(1 = ON; 0 = OFF)
@ixfragscanmode VARCHAR(8) = 'LIMITED', --(Valid inputs are DEFAULT, NULL, LIMITED, SAMPLED, or DETAILED. The default (NULL) is LIMITED)
@bpool_consumer bit = 1, --(1 = ON; 0 = OFF)
Expand Down Expand Up @@ -11891,10 +11891,14 @@ SELECT DISTINCT 'Weak_Password' AS Deviation, RTRIM(s.name) AS [Name], createdat
FROM @word d
INNER JOIN master.sys.syslogins s ON PWDCOMPARE(RTRIM(RTRIM(d.word)), s.[password]) = 1
UNION ALL
SELECT 'NULL_Passwords' AS Deviation, RTRIM(name) AS [Name], createdate AS [CreateDate]
FROM master.sys.syslogins
WHERE [password] IS NULL
AND isntname = 0
SELECT 'NULL_Passwords' AS Deviation, RTRIM(name) AS [Name], create_date AS [CreateDate]
FROM master.sys.sql_logins s
WHERE PWDCOMPARE('',s.password_hash)=1
--commenting out as all passwords are NULL in sys.syslogins
--SELECT 'NULL_Passwords' AS Deviation, RTRIM(name) AS [Name], createdate AS [CreateDate]
--FROM master.sys.syslogins
--WHERE [password] IS NULL
-- AND isntname = 0
AND name NOT IN ('MSCRMSqlClrLogin','##MS_SmoExtendedSigningCertificate##','##MS_PolicySigningCertificate##','##MS_SQLResourceSigningCertificate##','##MS_SQLReplicationSigningCertificate##','##MS_SQLAuthenticatorCertificate##','##MS_AgentSigningCertificate##','##MS_SQLEnableSystemAssemblyLoadingUser##')
UNION ALL
SELECT DISTINCT 'Name=Password' AS Deviation, RTRIM(s.name) AS [Name], createdate AS [CreateDate]
Expand Down