-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example of json-chema README.md #5145
base: main
Are you sure you want to change the base?
Conversation
the example was not working as the property name `model` is a reserved keyword.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your pull request! the change looks good! but the change on packages/json-schema/README.md
is missing, please run pnpm regen-docs
on repo root and after that it should be ready!
thanks again!
Thank you for submitting this PR! The README.md is generated by running Note: In your original change, you updated |
@satoshionoda please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
the example was not working as the property name
model
is a reserved keyword.