Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP] adds getStreamMetadata API #5153

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[HTTP] adds getStreamMetadata API #5153

wants to merge 8 commits into from

Conversation

chrisradek
Copy link
Member

Implements #4957

Link to design gist: https://gist.github.com/chrisradek/8b160bae56ceb1bf925933e1a2bb73c7

Design reviewed with TCGC team, in draft until I confirm this is the API we want to use for emitters.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 20, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http
Show changes

@typespec/http - feature ✏️

Adds getStreamMetadata JS API to simplify getting stream metadata from operation parameters and responses.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@chrisradek chrisradek marked this pull request as ready for review December 5, 2024 19:12
iscai-msft
iscai-msft approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from the standpoint of getting necessary info in tcgc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees

@iscai-msft iscai-msft

@witemple-msft witemple-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisradek @azure-sdk @iscai-msft @witemple-msft @markcowl