Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] add dependabot for python, add requirements.txt #5683

Merged
merged 17 commits into from
Jan 24, 2025
Merged

[python] add dependabot for python, add requirements.txt #5683

merged 17 commits into from
Jan 24, 2025

Conversation

iscai-msft
Copy link
Member

@iscai-msft iscai-msft commented Jan 21, 2025 •
edited
Loading

@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 21, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

@msyyc msyyc mentioned this pull request Jan 21, 2025
Closed
msyyc
msyyc requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR influence the way to install dependencies for test framework, please also make a PR which contains similar changes in autorest.python repo.

@iscai-msft
Copy link
Member Author

@msyyc there are differences between install_requires and requirements.txt (see stackoverflow here). I think we should reconsider how we're treating setup.py and install_reqs, but I'm ok to peel this out into a separate PR and change it when we migrate to pyproject.toml here

msyyc
msyyc approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me now.

@iscai-msft iscai-msft added this pull request to the merge queue Jan 24, 2025
Merged via the queue into microsoft:main with commit 981ab79 Jan 24, 2025
35 checks passed
@iscai-msft iscai-msft deleted the python/addDependabot branch January 24, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msyyc msyyc msyyc approved these changes

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add dependabot for @typespec/http-client-python in typespec repo
4 participants
@iscai-msft @azure-sdk @timotheeguerin @msyyc