Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imgui] Update to 1.90.1 #36122

Closed
wants to merge 1 commit into from

Conversation

waywardmonkeys
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 11, 2024
@MonicaLiu0311
Copy link
Contributor

Please get failure logs here:

[2/6] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP  -ID:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean -ID:\installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  -std:c++14 /showIncludes /FoCMakeFiles\imgui-node-editor.dir\imgui_node_editor_api.cpp.obj /FdCMakeFiles\imgui-node-editor.dir\imgui-node-editor.pdb /FS -c D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor_api.cpp
FAILED: CMakeFiles/imgui-node-editor.dir/imgui_node_editor_api.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP  -ID:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean -ID:\installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  -std:c++14 /showIncludes /FoCMakeFiles\imgui-node-editor.dir\imgui_node_editor_api.cpp.obj /FdCMakeFiles\imgui-node-editor.dir\imgui-node-editor.pdb /FS -c D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor_api.cpp
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_extra_math.inl(22): error C2084: function 'bool operator ==(const ImVec2 &,const ImVec2 &)' already has a body
D:\installed\x64-windows\include\imgui.h(2508): note: see previous definition of '=='
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_extra_math.inl(27): error C2084: function 'bool operator !=(const ImVec2 &,const ImVec2 &)' already has a body
D:\installed\x64-windows\include\imgui.h(2509): note: see previous definition of '!='
[3/6] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP  -ID:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean -ID:\installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  -std:c++14 /showIncludes /FoCMakeFiles\imgui-node-editor.dir\imgui_node_editor.cpp.obj /FdCMakeFiles\imgui-node-editor.dir\imgui-node-editor.pdb /FS -c D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp
FAILED: CMakeFiles/imgui-node-editor.dir/imgui_node_editor.cpp.obj 
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP  -ID:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean -ID:\installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  -std:c++14 /showIncludes /FoCMakeFiles\imgui-node-editor.dir\imgui_node_editor.cpp.obj /FdCMakeFiles\imgui-node-editor.dir\imgui-node-editor.pdb /FS -c D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_extra_math.inl(22): error C2084: function 'bool operator ==(const ImVec2 &,const ImVec2 &)' already has a body
D:\installed\x64-windows\include\imgui.h(2508): note: see previous definition of '=='
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_extra_math.inl(27): error C2084: function 'bool operator !=(const ImVec2 &,const ImVec2 &)' already has a body
D:\installed\x64-windows\include\imgui.h(2509): note: see previous definition of '!='
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(642): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(642): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(1203): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(1203): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(1648): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(1648): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(1667): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(1667): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3145): error C2264: 'operator ==': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3145): error C2088: '==': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3145): error C2264: 'operator ==': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3145): error C2088: '==': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3389): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3389): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3389): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3389): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3422): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3422): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3467): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3467): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3467): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3467): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3467): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3467): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3741): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3741): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3741): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3741): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3744): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3744): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3744): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(3744): error C2088: '!=': illegal for struct
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(5289): error C2264: 'operator !=': error in function definition or declaration; function not called
D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\imgui_node_editor.cpp(5289): error C2088: '!=': illegal for struct
[4/6] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP  -ID:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean -ID:\installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  -std:c++14 /showIncludes /FoCMakeFiles\imgui-node-editor.dir\crude_json.cpp.obj /FdCMakeFiles\imgui-node-editor.dir\imgui-node-editor.pdb /FS -c D:\b\imgui-node-editor\src\v0.9.3-73c822344c.clean\crude_json.cpp
ninja: build stopped: subcommand failed.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft January 12, 2024 02:21
@MonicaLiu0311
Copy link
Contributor

Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review".

@waywardmonkeys
Copy link
Contributor Author

There's a fix upstream for the build issue with imgui-node-editor but not yet a new release. I've asked about a new release.

@MonicaLiu0311
Copy link
Contributor

There's a fix upstream for the build issue with imgui-node-editor but not yet a new release. I've asked about a new release.

Upstream issue: thedmd/imgui-node-editor#274. Waiting for the upstream reply.

@waywardmonkeys
Copy link
Contributor Author

Closing in favor of #36699

@waywardmonkeys waywardmonkeys deleted the update-imgui branch February 14, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants