[ada-url] update to 3.0.1 #43594
[ada-url] update to 3.0.1 #43594
Conversation
FrankXie05
added
the
category:port-update
|
@FrankXie05 |
|
In that case you can add |
|
@dg0yt |
ports/ada-url/no-cpm.patch
Outdated
|
|
||
|
|
||
| add_library(ada::ada ALIAS ada) | ||
| +target_compile_features(ada PUBLIC cxx_std_20) |
There was a problem hiding this comment.
Why is this required? It should work as it is.
ports/ada-url/no-cpm.patch
Outdated
|
|
||
| if(ADA_TOOLS) | ||
| - add_subdirectory(tools) | ||
| +# add_subdirectory(tools) |
ports/ada-url/no-cpm.patch
Outdated
| - OPTIONS "CXXOPTS_BUILD_EXAMPLES NO" "CXXOPTS_BUILD_TESTS NO" "CXXOPTS_ENABLE_INSTALL YES" | ||
| -) | ||
| +find_package(fmt CONFIG REQUIRED) | ||
| +find_package(cxxopts CONFIG REQUIRED) |
There was a problem hiding this comment.
These changes are unnecessary. If you pass the correct build flag, CPM will never install a new package and only use the existing packages.
There was a problem hiding this comment.
Thank you for review.
I agree wiyh you.
These modifications are my trials for CI fails.
Now I undestand how to fix CI fails, I will revert these modifications.
Please wait a moment.
| - VERSION 3.2.0 | ||
| - OPTIONS "CXXOPTS_BUILD_EXAMPLES NO" "CXXOPTS_BUILD_TESTS NO" "CXXOPTS_ENABLE_INSTALL YES" | ||
| -) | ||
| +find_package(fmt CONFIG REQUIRED) |
There was a problem hiding this comment.
I believe this patch needs to be restored to ensure these come from their associated ports rather than being effectively vendored. @anonrig I believe you are mistaken. In particular, CPM is not given the find_package'd name of these packages, so I don't understand how it could ever resolve them correctly.
Building ada-url:[email protected]...
Trying to download ada-url-ada-v3.0.1.tar.gz using asset cache https://vcpkgassetcachewus.blob.core.windows.net/cache/3a81da352ad47395d83172f1477e8165483c5dc30923ba4387463a03aa01df5d6718dd54d22f568a654300e777b3eafce7f266504a27bfeb1f8de57503670dc4?*** SECRET ***
Download successful! Asset cache hit, did not try authoritative source https://github.com/ada-url/ada/archive/v3.0.1.tar.gz
-- Extracting source D:/downloads/ada-url-ada-v3.0.1.tar.gz
-- Using source at D:/b/ada-url/src/v3.0.1-d5321571b6.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows
CMake Warning at D:/installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:344 (message):
The following variables are not used in CMakeLists.txt:
CPM_USE_LOCAL_PACKAGES
Please recheck them and remove the unnecessary options from the
`vcpkg_cmake_configure` call.
If these options should still be passed for whatever reason, please use the
`MAYBE_UNUSED_VARIABLES` argument.
Call Stack (most recent call first):
ports/ada-url/portfile.cmake:19 (vcpkg_cmake_configure)
scripts/ports.cmake:196 (include)
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Performing post-build validation
Store success
Any fixed CI baseline entries are removed from that file../vcpkg x-add-version --alland committing the result.