Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wildcards] add new port #43663

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[wildcards] add new port #43663

wants to merge 4 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Feb 6, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 7, 2025
@MonicaLiu0311
Copy link
Contributor

Please get the failure logs for x64-osx here:

CMake Error at CMakeLists.txt:19 (configure_file):
  No such file or directory

-- Configuring incomplete, errors occurred!

The steps to view CI errors are: #38994 (comment)

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft February 7, 2025 02:38
@toge
Copy link
Contributor Author

toge commented Feb 7, 2025

@MonicaLiu0311
Thank you for your information。
This is exactly what I want!

@dg0yt
Copy link
Contributor

dg0yt commented Feb 7, 2025

CMake Error at CMakeLists.txt:19 (configure_file):
No such file or directory

Typical problem: Writing files in the source directory while vcpkg is concurrently configuring debug and release builds.
You must add DISABLE_PARALLEL_CONFIGURE to vcpkg_cmake_configure.

@toge
Copy link
Contributor Author

toge commented Feb 7, 2025

@dg0yt
Thanks a lot!
Now all check have passed!

@toge toge marked this pull request as ready for review February 7, 2025 08:24
@MonicaLiu0311
Copy link
Contributor

The usage test passed on x64-windows (header files found).

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft February 8, 2025 10:11
@toge
Copy link
Contributor Author

toge commented Feb 8, 2025

@MonicaLiu0311
Thank you for reviewing!
I will fix these issues soon.

@toge toge marked this pull request as ready for review February 9, 2025 15:44
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants