Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove commands for python.refreshTensorBoard and python.launchTensorBoard #24702

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

eleanorjboyd
Copy link
Member

No description provided.

@eleanorjboyd
Copy link
Member Author

@karthiknadig do you want these commands and all their references completely removed?

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip package*.json package.json and package-lock.json don't both need updating labels Jan 8, 2025
@eleanorjboyd
Copy link
Member Author

also please confirm that this change should not cause a package-lock.json change. Thanks

@karthiknadig
Copy link
Member

Yes and what you have is right.

@karthiknadig
Copy link
Member

@DonJayamanne Adding you as reviewer since you removed these command registrations recently

@eleanorjboyd eleanorjboyd marked this pull request as ready for review January 8, 2025 21:34
@eleanorjboyd eleanorjboyd merged commit 2ebfae9 into microsoft:main Jan 8, 2025
48 of 51 checks passed
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip package*.json package.json and package-lock.json don't both need updating skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants