Skip to content

Commit

Permalink
Merge pull request #1035 from microsoft/benibenj/accessible-wolf
Browse files Browse the repository at this point in the history
Update deprecated dependencies and move to Node 20
benibenj authored Aug 15, 2024
2 parents b347c2b + 6b64546 commit f7ed2e1
Showing 5 changed files with 736 additions and 155 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ Read the [**Documentation**](https://code.visualstudio.com/api/working-with-exte

## Requirements

[Node.js](https://nodejs.org/en/) at least `18.x.x`.
[Node.js](https://nodejs.org/en/) at least `20.x.x`.

### Linux

6 changes: 3 additions & 3 deletions build/azure-pipelines.yml
Original file line number Diff line number Diff line change
@@ -32,11 +32,11 @@ extends:
- script: npm run build
testPlatforms:
- name: Linux
nodeVersions: [18.x, 20.x]
nodeVersions: [20.x]
- name: MacOS
nodeVersions: [18.x, 20.x]
nodeVersions: [20.x]
- name: Windows
nodeVersions: [18.x, 20.x]
nodeVersions: [20.x]
testSteps:
- script: npm ci
- script: npm test
867 changes: 724 additions & 143 deletions package-lock.json

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@
"watch:test": "npm run test -- --watch"
},
"engines": {
"node": ">= 16"
"node": ">= 20"
},
"dependencies": {
"@azure/identity": "^4.1.0",
@@ -46,7 +46,7 @@
"cockatiel": "^3.1.2",
"commander": "^6.2.1",
"form-data": "^4.0.0",
"glob": "^7.0.6",
"glob": "^11.0.0",
"hosted-git-info": "^4.0.2",
"jsonc-parser": "^3.2.0",
"leven": "^3.1.0",
@@ -56,7 +56,7 @@
"parse-semver": "^1.1.1",
"read": "^1.0.7",
"semver": "^7.5.2",
"tmp": "^0.2.1",
"tmp": "^0.2.3",
"typed-rest-client": "^1.8.4",
"url-join": "^4.0.1",
"xml2js": "^0.5.0",
@@ -66,7 +66,7 @@
"devDependencies": {
"@microsoft/api-extractor": "^7.33.7",
"@types/cheerio": "^0.22.29",
"@types/glob": "^7.1.1",
"@types/glob": "^8.1.0",
"@types/hosted-git-info": "^3.0.2",
"@types/markdown-it": "^0.0.2",
"@types/mime": "^1",
@@ -95,4 +95,4 @@
"watch-files": "src/**",
"spec": "src/test/**/*.ts"
}
}
}
6 changes: 3 additions & 3 deletions src/package.ts
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import * as yazl from 'yazl';
import { ExtensionKind, Manifest } from './manifest';
import { ITranslations, patchNLS } from './nls';
import * as util from './util';
import glob from 'glob';
import { glob } from 'glob';
import minimatch from 'minimatch';
import markdownit from 'markdown-it';
import * as cheerio from 'cheerio';
@@ -200,7 +200,7 @@ export interface VSIX {
preRelease: boolean;
sponsorLink: string;
pricing: string;
executesCode:boolean;
executesCode: boolean;
}

export class BaseProcessor implements IProcessor {
@@ -1620,7 +1620,7 @@ async function collectAllFiles(
): Promise<string[]> {
const deps = await getDependencies(cwd, dependencies, dependencyEntryPoints);
const promises = deps.map(dep =>
promisify(glob)('**', { cwd: dep, nodir: true, dot: true, ignore: 'node_modules/**' }).then(files =>
glob('**', { cwd: dep, nodir: true, dot: true, ignore: 'node_modules/**' }).then(files =>
files.map(f => path.relative(cwd, path.join(dep, f))).map(f => f.replace(/\\/g, '/'))
)
);

0 comments on commit f7ed2e1

Please sign in to comment.