No diff colors in non-English Git commit message #133888
Comments
|
I think it's not because of non-English text, bit because it's treated as Go language Do you see same problem if you change language mode to Git Commit Message manually? May be related to automatic language detection. Is this issue reproducible in Insiders version? https://code.visualstudio.com/insiders/ /assign TylerLeonhardt |
|
Oops, sorry. Screenshot updated, problem persists. The grammar has the string Try this in Git Commit Message mode and you should see it as well. What I wish for is for the lines |
|
@IllusionMH thanks for jumping in! Based on the previous screenshot it sounded like it was autodetection but with the updated screenshot it appears to be an issue with the textmate grammar. Adding @eamodio and @lszomoru |
lszomoru
added
bug
lszomoru
added
terminal-external
upstream-issue-pending
|
Closing this as external until textmate/git.tmbundle#60 is addressed. |
|
https://github.com/textmate/git.tmbundle is dead, it was last updated in 2019. I think it would be better to break the dependency on that dead repo and accept changes directly into the (not dead) vscode repo. @lszomoru could we:
|
|
Adding @alexr00 as she manages the grammar files included in vscode. |
|
Opened #168847. |
Before this change, the upstream for the VSCode Git grammar was dead. Also, the test setup for that project has been EOL since 2014, so even just running the tests was difficult. The replacement grammar, unlike the current grammar: * Has a vscode-tmgrammar-test test suite that is runnable and passing and that will run in CI for any PRs (in the upstream project) * Has diff highlighting for Swedish as well as English (microsoft#133888) * Highlights touched files both in Swedish and in English Fixes microsoft#133888 Fixes microsoft#168847 Ref: <https://github.com/walles/git-commit-message-plus> And for the record, I was the one setting up the new Git Commit Message project. And it was fun!
Before this change, the upstream for the VSCode Git grammar was dead. Also, the test setup for that project has been EOL since 2014, so even just running the tests was difficult. The replacement grammar, unlike the current grammar: * Has a vscode-tmgrammar-test test suite that is runnable and passing and that will run in CI for any PRs (in the upstream project) * Has diff highlighting for Swedish as well as English (microsoft#133888) * Highlights touched files both in Swedish and in English Fixes microsoft#133888 Fixes microsoft#168847 Ref: <https://github.com/walles/git-commit-message-plus> And for the record, I was the one setting up the new Git Commit Message project. And it was fun!
* Unfreeze Git Commit Message grammar II Before this change, the upstream for the VSCode Git grammar was dead. Also, the test setup for that project has been EOL since 2014, so even just running the tests was difficult. The replacement grammar, unlike the current grammar: * Has a vscode-tmgrammar-test test suite that is runnable and passing and that will run in CI for any PRs (in the upstream project) * Has diff highlighting for Swedish as well as English (#133888) * Highlights touched files both in Swedish and in English Fixes #133888 Fixes #168847 Ref: <https://github.com/walles/git-commit-message-plus> And for the record, I was the one setting up the new Git Commit Message project. And it was fun! * Remedy review feedback Retain the line-too-long subject line highlighting. Improved to highlight only the too-long part, but same idea still. Special case English language file operations keywords and retain the previous classification of those. But fallback to op-and-filename classification when that fails (like it will for Swedish git for example). * Update colorize test result * Update script and cgmanifest --------- Co-authored-by: Alex Ross <[email protected]>
* Unfreeze Git Commit Message grammar II Before this change, the upstream for the VSCode Git grammar was dead. Also, the test setup for that project has been EOL since 2014, so even just running the tests was difficult. The replacement grammar, unlike the current grammar: * Has a vscode-tmgrammar-test test suite that is runnable and passing and that will run in CI for any PRs (in the upstream project) * Has diff highlighting for Swedish as well as English (microsoft#133888) * Highlights touched files both in Swedish and in English Fixes microsoft#133888 Fixes microsoft#168847 Ref: <https://github.com/walles/git-commit-message-plus> And for the record, I was the one setting up the new Git Commit Message project. And it was fun! * Remedy review feedback Retain the line-too-long subject line highlighting. Improved to highlight only the too-long part, but same idea still. Special case English language file operations keywords and retain the previous classification of those. But fallback to op-and-filename classification when that fails (like it will for Swedish git for example). * Update colorize test result * Update script and cgmanifest --------- Co-authored-by: Alex Ross <[email protected]>
Issue Type: Bug
Here's how VSCode highlights an English commit message template (from
git commit -v). Notice how the diff parts are highlighted.Here's how VSCode highlights a Swedish commit message template (from
git commit -v). Notice how the diff parts are not highlighted.Notes
The instructions in the grammar file says that PRs should be made to upstream here:
https://github.com/textmate/git.tmbundle/blob/master/Syntaxes/Git%20Commit%20Message.tmLanguage
However, that repo has a test suite requiring a Ruby version EOL since 2014 (textmate/git.tmbundle#59), and I failed to run that, so I can't do this.
I also filed this ticket with upstream (textmate/git.tmbundle#59), but the commit message grammar there hasn't been updated since 2016.
VS Code version: Code 1.60.2 (7f6ab54, 2021-09-22T11:59:27.195Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No
System Info
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Extensions (38)
A/B Experiments
The text was updated successfully, but these errors were encountered: