Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adopting a new git grammar #168847

Closed
alexr00 opened this issue Dec 12, 2022 · 1 comment · Fixed by #173195
Closed

Consider adopting a new git grammar #168847

alexr00 opened this issue Dec 12, 2022 · 1 comment · Fixed by #173195
Assignees
@alexr00
Labels
feature-request Request for new features or functionality grammar Syntax highlighting grammar insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Dec 12, 2022

#133888
@alexr00 alexr00 added feature-request Request for new features or functionality grammar Syntax highlighting grammar labels Dec 12, 2022
@alexr00 alexr00 added this to the Backlog milestone Dec 12, 2022
@alexr00 alexr00 self-assigned this Dec 12, 2022
@alexr00 alexr00 mentioned this issue Dec 12, 2022
Closed
@walles walles mentioned this issue Feb 2, 2023
Merged
walles added a commit to walles/vscode that referenced this issue Feb 2, 2023
@walles
Unfreeze Git Commit Message grammar II
761a485 
Before this change, the upstream for the VSCode Git grammar was dead.
Also, the test setup for that project has been EOL since 2014, so even
just running the tests was difficult.

The replacement grammar, unlike the current grammar:
* Has a vscode-tmgrammar-test test suite that is runnable and passing
  and that will run in CI for any PRs (in the upstream project)
* Has diff highlighting for Swedish as well as English (microsoft#133888)
* Highlights touched files both in Swedish and in English

Fixes microsoft#133888
Fixes microsoft#168847

Ref: <https://github.com/walles/git-commit-message-plus>

And for the record, I was the one setting up the new Git Commit Message
project. And it was fun!
walles added a commit to walles/vscode that referenced this issue Feb 2, 2023
@walles
Unfreeze Git Commit Message grammar II
2d4317c 
Before this change, the upstream for the VSCode Git grammar was dead.
Also, the test setup for that project has been EOL since 2014, so even
just running the tests was difficult.

The replacement grammar, unlike the current grammar:
* Has a vscode-tmgrammar-test test suite that is runnable and passing
  and that will run in CI for any PRs (in the upstream project)
* Has diff highlighting for Swedish as well as English (microsoft#133888)
* Highlights touched files both in Swedish and in English

Fixes microsoft#133888
Fixes microsoft#168847

Ref: <https://github.com/walles/git-commit-message-plus>

And for the record, I was the one setting up the new Git Commit Message
project. And it was fun!
@alexr00 alexr00 modified the milestones: Backlog, February 2023 Feb 7, 2023
alexr00 added a commit that referenced this issue Feb 7, 2023
@walles @alexr00
Unfreeze Git Commit Message grammar II (#173195)
f8c3f89 
* Unfreeze Git Commit Message grammar II

Before this change, the upstream for the VSCode Git grammar was dead.
Also, the test setup for that project has been EOL since 2014, so even
just running the tests was difficult.

The replacement grammar, unlike the current grammar:
* Has a vscode-tmgrammar-test test suite that is runnable and passing
  and that will run in CI for any PRs (in the upstream project)
* Has diff highlighting for Swedish as well as English (#133888)
* Highlights touched files both in Swedish and in English

Fixes #133888
Fixes #168847

Ref: <https://github.com/walles/git-commit-message-plus>

And for the record, I was the one setting up the new Git Commit Message
project. And it was fun!

* Remedy review feedback

Retain the line-too-long subject line highlighting. Improved to
highlight only the too-long part, but same idea still.

Special case English language file operations keywords and retain the
previous classification of those. But fallback to op-and-filename
classification when that fails (like it will for Swedish git for
example).

* Update colorize test result

* Update script and cgmanifest

---------

Co-authored-by: Alex Ross <[email protected]>
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 7, 2023
c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
@walles @alexr00 @c-claeys
Unfreeze Git Commit Message grammar II (microsoft#173195)
540bc50 
* Unfreeze Git Commit Message grammar II

Before this change, the upstream for the VSCode Git grammar was dead.
Also, the test setup for that project has been EOL since 2014, so even
just running the tests was difficult.

The replacement grammar, unlike the current grammar:
* Has a vscode-tmgrammar-test test suite that is runnable and passing
  and that will run in CI for any PRs (in the upstream project)
* Has diff highlighting for Swedish as well as English (microsoft#133888)
* Highlights touched files both in Swedish and in English

Fixes microsoft#133888
Fixes microsoft#168847

Ref: <https://github.com/walles/git-commit-message-plus>

And for the record, I was the one setting up the new Git Commit Message
project. And it was fun!

* Remedy review feedback

Retain the line-too-long subject line highlighting. Improved to
highlight only the too-long part, but same idea still.

Special case English language file operations keywords and retain the
previous classification of those. But fallback to op-and-filename
classification when that fails (like it will for Swedish git for
example).

* Update colorize test result

* Update script and cgmanifest

---------

Co-authored-by: Alex Ross <[email protected]>
@alexr00
Copy link
Member Author

alexr00 commented Feb 20, 2023

To verify make sure the integration tests pass.

@alexr00 alexr00 added the verification-needed Verification of issue is requested label Feb 21, 2023
@jrieken jrieken added the verified Verification succeeded label Feb 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality grammar Syntax highlighting grammar insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

Unfreeze Git Commit Message grammar II walles/vscode
3 participants
@jrieken @alexr00 @vscodenpa