Fixed svg end tag token #124220
Closed
Fixed svg end tag token #124220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnsoncodehk Thanks a lot for looking into this. Please see the file header: Can you make the PR against https://github.com/textmate/html.tmbundle ? Once accepted there we run our update script to bring in the version from there. |
|
Sorry I am not familiar with this repo, and currently I don't have time to check it. But I have shared this resolve to textmate/html.tmbundle#101. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #124215.
The problem is
\\s*can't catch new line character. Split(?i)(</)(\\2)\\s*(>)to two patterns by\\s*(>),(?i)(</)(svg)\\bto fixed.