-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for release please. #1532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this PR is still WIP, I'll switch is back to draft
Co-authored-by: Vincent Biret <[email protected]>
I would recommend using something other than
to avoid the red highlighting for comments in json That's the reason I used |
@SilasKenneth have you tried jsonc (json with comments) ? I don't have a strong opinion either way. I didn't know json5 was a thing until your last message, sorry for creating confusion here. https://json-5.com/json-vs-json5 |
I just tried it now. Looks like it achieves the desired output too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to merge, thanks for making the changes!
Microsoft Reviewers: Open in CodeFlow