Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for release please. #1532

Merged
merged 13 commits into from
May 24, 2024
Merged

Add config for release please. #1532

merged 13 commits into from
May 24, 2024

Conversation

SilasKenneth
Copy link
Member

@SilasKenneth SilasKenneth commented May 22, 2024

Microsoft Reviewers: Open in CodeFlow

@SilasKenneth SilasKenneth self-assigned this May 22, 2024
@SilasKenneth SilasKenneth requested a review from a team as a code owner May 22, 2024 10:00
@SilasKenneth SilasKenneth changed the base branch from dev to main May 22, 2024 10:00
@baywet baywet linked an issue May 22, 2024 that may be closed by this pull request
9 tasks
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this PR is still WIP, I'll switch is back to draft

README.md Outdated Show resolved Hide resolved
@baywet baywet marked this pull request as draft May 22, 2024 12:28
@SilasKenneth
Copy link
Member Author

I would recommend using something other than

```json

to avoid the red highlighting for comments in json
Screenshot 2024-05-22 154041


That's the reason I used json5. We can also use js. What do you think @baywet?

@baywet
Copy link
Member

baywet commented May 22, 2024

@SilasKenneth have you tried jsonc (json with comments) ? I don't have a strong opinion either way. I didn't know json5 was a thing until your last message, sorry for creating confusion here. https://json-5.com/json-vs-json5

@SilasKenneth
Copy link
Member Author

@SilasKenneth have you tried jsonc (json with comments) ? I don't have a strong opinion either way. I didn't know json5 was a thing until your last message, sorry for creating confusion here. https://json-5.com/json-vs-json5

I just tried it now. Looks like it achieves the desired output too.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to merge, thanks for making the changes!

@baywet baywet marked this pull request as ready for review May 24, 2024 12:04
@SilasKenneth SilasKenneth merged commit bd17894 into main May 24, 2024
7 checks passed
@SilasKenneth SilasKenneth deleted the chore/release-please-config branch May 24, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add release please configuration
2 participants