Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby version to 2.7.2 #330

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

SpaYco
Copy link
Collaborator

@SpaYco SpaYco commented Mar 25, 2021

As requested by @nidalaa, I've updated the Ruby version in the Gemfile to 2.7.2, I've also updated the README.md so it puts the right information in the Ruby version.

@SpaYco SpaYco requested a review from bolah2009 March 25, 2021 23:00
Copy link
Collaborator

@bolah2009 bolah2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... I think there's one more place to do the update. Also, have you tried testing if the app still works well with the version bump?

@SpaYco
Copy link
Collaborator Author

SpaYco commented Mar 26, 2021

will do!

@SpaYco
Copy link
Collaborator Author

SpaYco commented Mar 26, 2021

@bolah2009 I updated .ruby-version, and tested it and it's working fine!

I also updated Gemfile.lock, since it causes some errors during installs.

@SpaYco SpaYco requested a review from bolah2009 March 26, 2021 21:50
@euqueme
Copy link
Collaborator

euqueme commented Apr 12, 2021

Thank you @SpaYco I also think this is good to go 👌 @bolah2009 what do you say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants