Deploying on Heroku #387
Open
Deploying on Heroku #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Social media website
…bsite into milestone-2
Social media website
social-media-website
Deploing to heroku
SajjadAhmad14
suggested changes
Jun 22, 2021
There was a problem hiding this comment.
Changes Required ♻️
"Change is inevitable. Change is constant. -Benjamin Disraeli"
Hello, you have been doing a tremendous job so far 👌
To Highlight 🎉
- PR title and summary are descriptive.
To Improve 🙏
- Link to Heroku in README file should be added. There is no link to the live demo in the README file of the master branch. Please see this screenshot.
- Project does not have a development branch. You should have followed Git flow already in previous milestones. You should already have merged a pull request from development to the master branch.
Happy Coding ☺️
If you have any questions you can comment here in this PR or can always connect with me on slack ( @sajjad Ahmad ).
george-shammar
suggested changes
Jun 22, 2021
There was a problem hiding this comment.
STATUS: CHANGES REQUIRED ♻️ ♻️ 🚧
Highlight
You have deployed application and it's available online. Good job. 👍 👏
Please see the required changes below:
- The link to the live version of the application needs to be in your README. The "Live Demo" and "Deployment" sections in your README is empty with no link.
[OPTIONAL]
- You have no development branch. I'm confused as to how that is possible seeing this is the last milestone for this project.
- Github action is also not properly set up.
The optional changes are being made optional just because you've passed the milestones where it was enforced but I strongly recommend you fix it now.
Please submit another CRR when you're ready.
Cheers and happy coding. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deployed our project on Heroku at this link https://evening-earth-80698.herokuapp.com/users/sign_in. In Readme, on a master branch should be two links for Heroku, in the Live demo and Deployment section. We deployed from the master branch and merged everything previously