Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 #390

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Milestone 1 #390

wants to merge 21 commits into from

Conversation

DanSam5K
Copy link

In this milestone

  • I was able to configure the project to reflect the recent files updates dependencies.
  • Configure and create files migration to use Pg for development and migrate to a database
  • Generate friendship model, active-record associations and add helper methods for friendship in the user model
  • Update rubocop and fix linters error.

@DanSam5K DanSam5K closed this Jun 25, 2021
@DanSam5K DanSam5K reopened this Jun 25, 2021
Copy link

@BrianSammit BrianSammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: INVALID 🟡

Hello @DanSam5K, Your project will be marked as invalid because your linters are not working on the GitHub actions. Please fix this and send it again for another review.

  • Enable the GitHub Actions in the Actions tab.
  • Create the feature/branch and push.
  • Start working on the milestone as usual.
  • Open a PR from the feature/branch when the work is done.

Copy link

@elisha2kyakpo1 elisha2kyakpo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: INVALID 🟡

Hello @DanSam5K, Your project will be marked as invalid because you are requesting to merge into a master branch of the microverse, instead of the development branch of your own.

  • Create a development branch from which you will need to create a feature branch.

When you are done, you can submit another PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants