Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTA - Disparities #13

Merged
merged 9 commits into from
Jul 18, 2024
Merged

UTA - Disparities #13

merged 9 commits into from
Jul 18, 2024

Conversation

SRBandekar
Copy link
Contributor

Description

Please include a brief description of your change.

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Copy link

Run validation on files: 2024-06-25-UTA-ImmunoSEIRS.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, asian, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, other, inc death

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

@LucieContamin
Copy link
Contributor

Hi @SRBandekar ,

Thank you for the submission.
I have some questions about your submission files.
First, would it be possible to remove the empty model-output/UTA-ImmunoSEIRS/sample please?
Next, I wanted to confirm that I understand correctly your sample id numbering: the only difference between each run is stochasticity (run_grouping all 1) and the stochastic runs are grouped by location, horizon, race_ethnicity and target. Is that correct?
And last, would it be possible to add at least a metadata file with your submission? I cannot merge it without metadata file.

Please let me know if any issues or questions,

Thanks, Lucie

Copy link

Run validation on files: 2024-06-25-UTA-ImmunoSEIRS.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, asian, inc death
🟡 Warning 505: Some location/target/scenario groups have a unique value for the whole projection period. Please verify: 2020-11-15, A-2020-05-01, 37, other, inc death

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

Copy link

Run validation on files: 2024-06-25-UTA-ImmunoSEIRS.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

2 similar comments
Copy link

Run validation on files: 2024-06-25-UTA-ImmunoSEIRS.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

Copy link

Run validation on files: 2024-06-25-UTA-ImmunoSEIRS.gz.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

@SRBandekar
Copy link
Contributor Author

Regarding this question:
"Next, I wanted to confirm that I understand correctly your sample id numbering: the only difference between each run is stochasticity (run_grouping all 1) and the stochastic runs are grouped by location, horizon, race_ethnicity and target. Is that correct?"

Yes, that is correct.

@LucieContamin
Copy link
Contributor

Hi @SRBandekar ,

Thank you for the update, I have some minor remarks for the metadata file:

  • the filename does not need to include "metadata-", it should only be your team abbr-model abbr.yaml
  • the model name includes your team name, is that expected?

Thanks, Lucie

@SRBandekar
Copy link
Contributor Author

HI @LucieContamin

I shall rename the metadata file.

To the second question:
team_name: UTA
model_name: ImmunoSEIRS
model_abbr: UTA-ImmunoSEIRS

@LucieContamin
Copy link
Contributor

HI @SRBandekar ,

Thanks for renaming the file.
To answer the 2nd question, in the documentation we have this section:

"The team-model abbreviation used in all the file names must be in the format of [team_abbr]-[model_abbr], where each of the [team_abbr] and [model_abbr] are text strings that are each less than 15 alphanumeric characters that do not include a hyphen or whitespace."

So if in your metadata you have:
team_name: UTA
model_name: ImmunoSEIRS
model_abbr: UTA-ImmunoSEIRS
The model_abbr will not be accepted:

"An abbreviated name for your model that is less than 30 alphanumeric characters (_ also accepted, please avoid using other punctuation characters including -, /, etc.)."

But also following all your file name, it should be:
team_abbr: UTA
model_abbr: ImmunoSEIRS

The first version you had is accepted, I was just checking it was expected. The team name and model name are used on the GitHub README team section in the website team information. So for example, on the covid-19 SMH website, your team is currently listed as: "University of Texas at Austin - ImmunoSEIRS", if for this round you use another model, I will add a new item in the list name using the team name and model name but if it's the same model I will not change it. So it's just to check that. Sorry if it was not clear.

Please let me know if you have any questions or need more information,

THanks,
Lucie

@SRBandekar
Copy link
Contributor Author

I believe I have done the needful and the contents in the metadata file seems correct to me.

Thank you.

@LucieContamin LucieContamin merged commit 0fa47cb into midas-network:main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants