Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload submission file for phase 1 #20

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

Qing1011
Copy link
Contributor

Description

Please include a brief description of your change.

Checklist

  • Specify a proper PR title with your team name.
  • All validation checks ran successfully on your branch. Instructions to run the tests locally is present here.

Copy link

Run validation on files: 2024-07-16-cumt-seivrcm.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

@Qing1011
Copy link
Contributor Author

phase2 submission for cumt

@LucieContamin
Copy link
Contributor

Hi @Qing1011 ,

Thank you for your submission, I have some questions about it.

First, I just wanted to verify that I understand correctly the sample ID numbering: there is no stochasticity, every models runs has a different run_grouping "grouped" by race_ethnicity, location, horizon, scenario, and, target. Is that correct?
Also, it seems that the submission is missing inc inf for latino , for the location 06, would it be possible to fix it, please?

Please let me know if any issues or questions,
Best, Lucie

@Qing1011
Copy link
Contributor Author

@LucieContamin Hi Lucie

Thank you very much for pointing out. I will fix it today.

Many thanks

Copy link

Run validation on files: 2024-07-16-cumt-seivrcm.parquet

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

@Qing1011
Copy link
Contributor Author

Hi @LucieContamin,

I am not sure if i have successfully updated the submission?

Thank you

@LucieContamin
Copy link
Contributor

Hi @Qing1011 ,

Thank you for your submission, I have some questions about it.

First, would it be possible to please validate that I understand correctly the sample ID numbering: there is no stochasticity, every models runs has a different run_grouping "grouped" by race_ethnicity, location, horizon, scenario, and, target. Is that correct?
Also, it seems that the submission is missing inc inf for other , for the location 06, would it be possible to fix it, please?

I am updating the validation, an error should appear if a required value is missing in the next version.

Please let me know if any issues or questions,
Best, Lucie

@Qing1011
Copy link
Contributor Author

Hi @LucieContamin
There is no stochasticity in each run.

@Qing1011
Copy link
Contributor Author

Hi @LucieContamin

I thought i have uploaded the new submission with the inc inf for location 06 of latino.
Do you mean that they are not updated?

@LucieContamin
Copy link
Contributor

The new submission has been updated but it seems that it is missing inc inf for the race_ethnicity other , for the location 06, would it be possible to look into it, please?

Copy link

Run validation on files: 2024-07-16-cumt-seivrcm.parquet

Required values:

No missing required value found

Columns:

No errors or warnings found on the column names and numbers

Scenarios:

No errors or warnings found on scenario name and scenario id columns

Origin Date Column:

No errors or warnings found on the column 'origin_date'

Value and Type Columns:

No errors or warnings found on Value and Type columns

Target Columns:

🟡 Warning 602: No value found associated with the targets: inc death (optional), inc inf (optional), inc case (optional); output_type: quantile.

Locations:

No errors or warnings found on Location

Sample:

No errors or warnings found on Sample

Quantiles:

No errors or warnings found on quantiles values and format

Race Ethnicity:

No errors or warnings found on race_ethnicity

@Qing1011
Copy link
Contributor Author

@LucieContamin
I am very sorry about the missing. Hope this time i did not miss anything.

@LucieContamin
Copy link
Contributor

thanks for the update! it looks all good now

@LucieContamin LucieContamin merged commit 744c6a4 into midas-network:main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants