Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background (noise and lights) with dvh #957

Merged
merged 1 commit into from
May 19, 2024

Conversation

dresandev
Copy link
Contributor

Descripción

Se hace que el background no se reposicione en los dispositivos con viewport dinámico.

Cambios propuestos

Se da altura explicita de 100vh a los elementos parte del background (Noise and Lights)

Capturas de pantalla (si corresponde)

Estado inicial:
image

Al hacer scroll (Antes):
image

Al hacer scroll (Despúes):
image

Comprobación de cambios

  • He revisado que no haya ninguna PR (pull request) ya abierta con un problema similar, siguiendo el apartado de buenas prácticas
  • He revisado localmente los cambios para asegurarme de que no haya errores ni problemas.
  • He probado estos cambios en múltiples dispositivos y navegadores para asegurarme de que la landing page se vea y funcione correctamente.
  • He actualizado la documentación, si corresponde.

Copy link

vercel bot commented May 19, 2024

@dresandev is attempting to deploy a commit to the midudev pro Team on Vercel.

A member of the Team first needs to authorize it.

@midudev midudev merged commit fc79254 into midudev:main May 19, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants