Simplify CanonicalName #1494
Merged
Simplify CanonicalName #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was previously changed from using strings.ToLower to a custom loop to ensure it only lowercases ASCII characters. This was more complicated than it needed to be and introduced more allocations than is necessary. Instead of that approach we call strings.Map with a simple ASCII lowercase mapping function. Sadly we still use the nice ASCII-only fast path that strings.ToLower had, but it's unlikely to be worth all the extra code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was previously changed from using
strings.ToLowerto a custom loop to ensure it only lowercases ASCII characters. This was more complicated than it needed to be and introduced more allocations than is necessary.Instead of that approach we call
strings.Mapwith a simple ASCII lowercase mapping function. Sadly we still use the nice ASCII-only fast path thatstrings.ToLowerhad, but it's unlikely to be worth all the extra code.Updates #1434
Updates #1470