Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a working SMTP client. #1045

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add a working SMTP client. #1045

merged 3 commits into from
Dec 4, 2023

Conversation

drewc
Copy link
Collaborator

@drewc drewc commented Nov 17, 2023

Needs further documenting but works and in use!

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for elastic-ritchie-8f47f9 ready!

Name Link
🔨 Latest commit 6081205
🔍 Latest deploy log https://app.netlify.com/sites/elastic-ritchie-8f47f9/deploys/656d5b1a2bd3a80008c13a73
😎 Deploy Preview https://deploy-preview-1045--elastic-ritchie-8f47f9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@drewc drewc marked this pull request as draft November 17, 2023 07:03
@drewc drewc changed the title [WIP] Add a working SMTP client. Needs some cleaning but almost done! Add a working SMTP client. Needs some cleaning but almost done! Dec 1, 2023
@drewc drewc marked this pull request as ready for review December 1, 2023 02:01
@drewc drewc changed the title Add a working SMTP client. Needs some cleaning but almost done! Add a working SMTP client. Dec 1, 2023
@@ -0,0 +1,23 @@
# SMTP: Simple Mail Tranfser Protocol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyop


(import :std/net/smtp)

> (def mail (smtp-connect "localhost:8025"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the connect automatically do the SSL upgrade? That deserves a comment.

@@ -0,0 +1,902 @@
#+TITLE: SMTP: Simple Mail Tranfser Protocol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyop

:PROPERTIES:
:EXPORT_FILE_NAME: ../../../../doc/reference/std/net/smtp.md
:EXPORT_OPTIONS: toc:nil
:EXPORT_TITLE: SMTP: Simple Mail Tranfser Protocol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyop

:EXPORT_OPTIONS: toc:nil
:EXPORT_TITLE: SMTP: Simple Mail Tranfser Protocol
:END:
** SMTP: Simple Mail Tranfser Protocol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyop


The easy way to connect and interact with an SMTP server.

(ssl-context (default-client-ssl-context))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this line do?

#+begin_src scheme :tangle api.ss
(def (send-mail smtp return-path forward-path . data)
(using (smtp : SMTP)
(def sredaeh []) ;;(headers interted)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inverted? reversed?


#+begin_src sh
sudo apt install postfix
#+end_src
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who runs these commands in what context?

@@ -0,0 +1,902 @@
#+TITLE: SMTP: Simple Mail Tranfser Protocol

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bigger issue with org-mode: maintenance.

Unless the system enforces generation from the org file that becomes the source code (at which point the generated files are excluded from git), then what of this redundant representation of code? Are maintainers going to keep the two in sync? Edit only the org-mode then regenerate the code? (how?) Edit only the code and let the org-mode stay out of date?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The answer "for now, drewc is maintainer" is fine with me if it's fine with @vyzo — but then it needs a comment on the top of each and every relevant .ss file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants